You are viewing a plain text version of this content. The canonical link for it is here.
Posted to modperl-cvs@perl.apache.org by st...@apache.org on 2003/09/16 21:51:06 UTC

cvs commit: modperl/src/modules/perl Apache.xs

stas        2003/09/16 12:51:06

  Modified:    src/modules/perl Apache.xs
  Log:
  s/FALSE/GV_ADDWARN/ in gv_fetchpv() which adds no overhead, but prints a
  warning if the pv doesn't exist. suggested by Tim Bunce.
  
  Revision  Changes    Path
  1.129     +2 -1      modperl/src/modules/perl/Apache.xs
  
  Index: Apache.xs
  ===================================================================
  RCS file: /home/cvs/modperl/src/modules/perl/Apache.xs,v
  retrieving revision 1.128
  retrieving revision 1.129
  diff -u -u -r1.128 -r1.129
  --- Apache.xs	6 Jul 2003 04:51:20 -0000	1.128
  +++ Apache.xs	16 Sep 2003 19:51:06 -0000	1.129
  @@ -1134,7 +1134,8 @@
   	sv_setiv(sendh, 0);
       }
       else {
  -	CV *cv = GvCV(gv_fetchpv("Apache::write_client", FALSE, SVt_PVCV));
  +        /* should exist already */
  +        CV *cv = GvCV(gv_fetchpv("Apache::write_client", GV_ADDWARN, SVt_PVCV));
   	soft_timeout("mod_perl: Apache->print", r);
   	PUSHMARK(mark);
   #ifdef PERL_OBJECT