You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/24 12:40:51 UTC
[GitHub] [arrow-rs] timvw opened a new pull request, #1616: Implement Basic FlightSQL Client #1413
timvw opened a new pull request, #1616:
URL: https://github.com/apache/arrow-rs/pull/1616
# Which issue does this PR close?
Closes #1413
##
Client application replicates functionality in [FlightSqlClientDemoAp](https://github.com/apache/arrow/blob/master/java/flight/flight-sql/src/main/java/org/apache/arrow/flight/sql/example/FlightSqlClientDemoApp.java) and works against [FlightSqlExample](https://github.com/apache/arrow/blob/master/java/flight/flight-sql/src/test/java/org/apache/arrow/flight/sql/example/FlightSqlExample.java)
cargo run --bin client --features="flight-sql-experimental" Execute "select * from app.inttable"
+----+--------------+-------+-----------+
| ID | KEYNAME | VALUE | FOREIGNID |
+----+--------------+-------+-----------+
| 1 | one | 1 | 1 |
| 2 | zero | 0 | 1 |
| 3 | negative one | -1 | 1 |
+----+--------------+-------+-----------+
+----+---------+-------+-----------+
| ID | KEYNAME | VALUE | FOREIGNID |
+----+---------+-------+-----------+
+----+---------+-------+-----------+
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] timvw commented on a diff in pull request #1616: Implement Basic FlightSQL Client #1413
Posted by GitBox <gi...@apache.org>.
timvw commented on code in PR #1616:
URL: https://github.com/apache/arrow-rs/pull/1616#discussion_r860756344
##########
arrow-flight/examples/client.md:
##########
@@ -0,0 +1,101 @@
+<!---
Review Comment:
Agreed that this can be a helpful tool for a wider audience. I have moved the example/client.rs to bin/flightsqlclient.rs and updated the documentation accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1616: Implement Basic FlightSQL Client #1413
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #1616:
URL: https://github.com/apache/arrow-rs/pull/1616#issuecomment-1191842476
cc @avantgardnerio here is some work related to making a FlightSQL client
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold closed pull request #1616: Implement Basic FlightSQL Client #1413
Posted by GitBox <gi...@apache.org>.
tustvold closed pull request #1616: Implement Basic FlightSQL Client #1413
URL: https://github.com/apache/arrow-rs/pull/1616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #1616: Implement Basic FlightSQL Client #1413
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #1616:
URL: https://github.com/apache/arrow-rs/pull/1616#issuecomment-1120540627
Triggered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1616: Implement Basic FlightSQL Client #1413
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #1616:
URL: https://github.com/apache/arrow-rs/pull/1616#issuecomment-1111371386
I hope to find time to review this tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] wangfenjin commented on pull request #1616: Implement Basic FlightSQL Client #1413
Posted by GitBox <gi...@apache.org>.
wangfenjin commented on PR #1616:
URL: https://github.com/apache/arrow-rs/pull/1616#issuecomment-1109212676
@timvw I pushed my WIP code for your reference, you can take a look if you are interested.
https://github.com/wangfenjin/arrow-rs/commit/7da031d7debef6ef683e28bc0961b63227dc4a5f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] timvw commented on pull request #1616: Implement Basic FlightSQL Client #1413
Posted by GitBox <gi...@apache.org>.
timvw commented on PR #1616:
URL: https://github.com/apache/arrow-rs/pull/1616#issuecomment-1109573284
@wangfenjin Surprisingly I had started creating a similar flight sql client yesterday, threw it away, started from your WIP and updated the example client app..
Main areas that need attention:
* make client generic again (currently switched to explicit tonic::transport::Channel)
* action and update (commented them out)
* iterating over streaming flightdata
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] timvw commented on a diff in pull request #1616: Implement Basic FlightSQL Client #1413
Posted by GitBox <gi...@apache.org>.
timvw commented on code in PR #1616:
URL: https://github.com/apache/arrow-rs/pull/1616#discussion_r860507195
##########
arrow-flight/src/sql/mod.rs:
##########
@@ -18,7 +18,7 @@
use arrow::error::{ArrowError, Result as ArrowResult};
use prost::Message;
-mod gen {
+pub mod gen {
Review Comment:
Correct. Updated code accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #1616: Implement Basic FlightSQL Client #1413
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #1616:
URL: https://github.com/apache/arrow-rs/pull/1616#issuecomment-1358004362
Closing in favour of https://github.com/apache/arrow-rs/pull/3207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #1616: Implement Basic FlightSQL Client #1413
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1616:
URL: https://github.com/apache/arrow-rs/pull/1616#issuecomment-1120551940
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1616?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1616](https://codecov.io/gh/apache/arrow-rs/pull/1616?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (202e0ec) into [master](https://codecov.io/gh/apache/arrow-rs/commit/22e9f9513ce2d0356b8fa43788e5a957b056985c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (22e9f95) will **decrease** coverage by `0.22%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #1616 +/- ##
==========================================
- Coverage 83.02% 82.79% -0.23%
==========================================
Files 193 194 +1
Lines 55612 55764 +152
==========================================
- Hits 46174 46172 -2
- Misses 9438 9592 +154
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1616?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow-flight/src/sql/client.rs](https://codecov.io/gh/apache/arrow-rs/pull/1616/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3ctZmxpZ2h0L3NyYy9zcWwvY2xpZW50LnJz) | `0.00% <0.00%> (ø)` | |
| [arrow-flight/src/sql/mod.rs](https://codecov.io/gh/apache/arrow-rs/pull/1616/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3ctZmxpZ2h0L3NyYy9zcWwvbW9kLnJz) | `0.00% <ø> (ø)` | |
| [arrow-flight/src/sql/server.rs](https://codecov.io/gh/apache/arrow-rs/pull/1616/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3ctZmxpZ2h0L3NyYy9zcWwvc2VydmVyLnJz) | `0.00% <0.00%> (ø)` | |
| [arrow/src/error.rs](https://codecov.io/gh/apache/arrow-rs/pull/1616/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2Vycm9yLnJz) | `21.56% <0.00%> (-2.88%)` | :arrow_down: |
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/1616/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `65.98% <0.00%> (-0.23%)` | :arrow_down: |
| [parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow-rs/pull/1616/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZW5jb2RpbmdzL2VuY29kaW5nLnJz) | `93.37% <0.00%> (-0.19%)` | :arrow_down: |
| [arrow/src/array/transform/mod.rs](https://codecov.io/gh/apache/arrow-rs/pull/1616/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L3RyYW5zZm9ybS9tb2QucnM=) | `86.57% <0.00%> (-0.12%)` | :arrow_down: |
| [arrow/src/datatypes/datatype.rs](https://codecov.io/gh/apache/arrow-rs/pull/1616/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9kYXRhdHlwZS5ycw==) | `66.80% <0.00%> (+0.39%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1616?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1616?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [22e9f95...202e0ec](https://codecov.io/gh/apache/arrow-rs/pull/1616?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] HaoYang670 commented on pull request #1616: Implement Basic FlightSQL Client #1413
Posted by GitBox <gi...@apache.org>.
HaoYang670 commented on PR #1616:
URL: https://github.com/apache/arrow-rs/pull/1616#issuecomment-1120524321
@alamb @viirya Could you please help to trigger the CI processes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1616: Implement Basic FlightSQL Client #1413
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #1616:
URL: https://github.com/apache/arrow-rs/pull/1616#issuecomment-1121040702
Thanks @timvw -- I am sorry I haven't spent much time helping to review this code. If you think it is ready to do so I'll try and give it a thorough review later this week
Thanks again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] wangfenjin commented on a diff in pull request #1616: Implement Basic FlightSQL Client #1413
Posted by GitBox <gi...@apache.org>.
wangfenjin commented on code in PR #1616:
URL: https://github.com/apache/arrow-rs/pull/1616#discussion_r860485894
##########
arrow-flight/examples/client.md:
##########
@@ -0,0 +1,101 @@
+<!---
Review Comment:
I think we can move this to a bin/ folder and make it as a general and useful client for flight-sql servers, will benefit all flight-sql ecosystem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] wangfenjin commented on pull request #1616: Implement Basic FlightSQL Client #1413
Posted by GitBox <gi...@apache.org>.
wangfenjin commented on PR #1616:
URL: https://github.com/apache/arrow-rs/pull/1616#issuecomment-1107973859
Thanks for the PR!
Actually I think what we expected is a client API that can help user to build the example you showed in here. Such as we add a src/sql/client.rs to implement the API similar to [cpp-client-api](https://github.com/apache/arrow/blob/master/cpp/src/arrow/flight/sql/client.h), and then use the client api in examples/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] wangfenjin commented on pull request #1616: Implement Basic FlightSQL Client #1413
Posted by GitBox <gi...@apache.org>.
wangfenjin commented on PR #1616:
URL: https://github.com/apache/arrow-rs/pull/1616#issuecomment-1121126210
It's still WIP, maybe we can mark it as draft for now @timvw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] timvw commented on pull request #1616: Implement Basic FlightSQL Client #1413
Posted by GitBox <gi...@apache.org>.
timvw commented on PR #1616:
URL: https://github.com/apache/arrow-rs/pull/1616#issuecomment-1108239830
Got it. Will try to find some time to factor out the (ipc/conversion) parts and see what would make sense in a client-api..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] timvw commented on pull request #1616: Implement Basic FlightSQL Client #1413
Posted by GitBox <gi...@apache.org>.
timvw commented on PR #1616:
URL: https://github.com/apache/arrow-rs/pull/1616#issuecomment-1107833842
Some cleanup/suggestions for cleanup are very welcome (I'm still very new to writing rust code, most definitely will want to make the error handling more rust idiomatic..)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] wangfenjin commented on a diff in pull request #1616: Implement Basic FlightSQL Client #1413
Posted by GitBox <gi...@apache.org>.
wangfenjin commented on code in PR #1616:
URL: https://github.com/apache/arrow-rs/pull/1616#discussion_r860486242
##########
arrow-flight/src/sql/mod.rs:
##########
@@ -18,7 +18,7 @@
use arrow::error::{ArrowError, Result as ArrowResult};
use prost::Message;
-mod gen {
+pub mod gen {
Review Comment:
We don't need to make it pub as we `pub use gen::* `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org