You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2010/07/17 05:26:36 UTC

DO NOT REPLY [Bug 49165] Enhancement - Allow %{TIME_FORMAT}t As Configuration for AccessLogValve

https://issues.apache.org/bugzilla/show_bug.cgi?id=49165

Alexander Shirkov <sg...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|dev@tomcat.apache.org       |sgdread@gmail.com

--- Comment #1 from Alexander Shirkov <sg...@gmail.com> 2010-07-16 23:26:31 EDT ---
Created an attachment (id=25778)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25778)
#49165 fix (added %t{TIME_FORMAT} support)

Introduced new format for %t for AccesLogValve.
- new format %{TIME_FORMAT}t available. 
- if custom pattern contains milliseconds field, then optimizations, which
performs new current date time object creation only once per 1000 millis, will
be turned off.
- unit tests for added/changed functionality
- performance tests

Results of perfomance testing (tested on MacOS X 10.6.4):
AccessLogValve: 5 threads and 1000000 iterations using oldValve           took
8381ms
AccessLogValve: 5 threads and 1000000 iterations using newValve           took
7742ms
AccessLogValve: 5 threads and 1000000 iterations using newValveWithMillis took
8651ms
AccessLogValve: 5 threads and 2000000 iterations using oldValve           took
16864ms
AccessLogValve: 5 threads and 2000000 iterations using newValve           took
15945ms
AccessLogValve: 5 threads and 2000000 iterations using newValveWithMillis took
16806ms
AccessLogValve: 5 threads and 3000000 iterations using oldValve           took
25010ms
AccessLogValve: 5 threads and 3000000 iterations using newValve           took
24575ms
AccessLogValve: 5 threads and 3000000 iterations using newValveWithMillis took
26674ms
AccessLogValve: 5 threads and 4000000 iterations using oldValve           took
33775ms
AccessLogValve: 5 threads and 4000000 iterations using newValve           took
33043ms
AccessLogValve: 5 threads and 4000000 iterations using newValveWithMillis took
33796ms

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org