You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/12/07 12:42:54 UTC
[GitHub] [camel-quarkus] ppalaga opened a new pull request #3359: Workaround for NoSuchFileException: .../target/classes when executing a
ppalaga opened a new pull request #3359:
URL: https://github.com/apache/camel-quarkus/pull/3359
codegen task https://github.com/quarkusio/quarkus/issues/21718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aloubyansky commented on a change in pull request #3359: Workaround for NoSuchFileException: .../target/classes when executing a
Posted by GitBox <gi...@apache.org>.
aloubyansky commented on a change in pull request #3359:
URL: https://github.com/apache/camel-quarkus/pull/3359#discussion_r764391615
##########
File path: integration-tests/avro/pom.xml
##########
@@ -62,6 +62,7 @@
<plugin>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-maven-plugin</artifactId>
+ <extensions>true</extensions><!-- Workaround for https://github.com/quarkusio/quarkus/issues/21718 -->
Review comment:
`build` may re-use the one bootstraped in `generate-code`. Otherwise, in general, every module build should have its own bootstrap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #3359: Workaround for NoSuchFileException: .../target/classes when executing a
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #3359:
URL: https://github.com/apache/camel-quarkus/pull/3359#discussion_r764344277
##########
File path: integration-tests/avro/pom.xml
##########
@@ -62,6 +62,7 @@
<plugin>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-maven-plugin</artifactId>
+ <extensions>true</extensions><!-- Workaround for https://github.com/quarkusio/quarkus/issues/21718 -->
Review comment:
> What is the default version of extensions ?
`false`
> Why we don't have a value for it ?
`true` is only needed if a plugin should act as Maven extension - i.e. have access to more Maven APIs than usual plugins.
Here I am trying to eliminate the failure of second `mvnd` invocation, that happens only with projects where we invoke `quarkus-maven-plugin` 's generate-code` goal. Without `<extensions>true</extensions>` some cache inside `quarkus-maven-plugin` does not get cleared via `AbstractMavenLifecycleParticipant`, because `AbstractMavenLifecycleParticipant` are only honored in Maven extensions.
This helps to get rid of the failure, but it is still a good question whether the plugin works correctly in the rest of the test modules (even though it does not fail there).
WDYT @aloubyansky do we need to have `<extensions>true</extensions>` also in test modules where second mvnd invocation does not fail? - i.e. does the `build` mojo assume/require a fresh bootstrap on every maven invocation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on a change in pull request #3359: Workaround for NoSuchFileException: .../target/classes when executing a
Posted by GitBox <gi...@apache.org>.
zbendhiba commented on a change in pull request #3359:
URL: https://github.com/apache/camel-quarkus/pull/3359#discussion_r764153878
##########
File path: integration-tests/avro/pom.xml
##########
@@ -62,6 +62,7 @@
<plugin>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-maven-plugin</artifactId>
+ <extensions>true</extensions><!-- Workaround for https://github.com/quarkusio/quarkus/issues/21718 -->
Review comment:
By doc I mean this : https://quarkus.io/guides/maven-tooling
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #3359: Workaround for NoSuchFileException: .../target/classes when executing a
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #3359:
URL: https://github.com/apache/camel-quarkus/pull/3359#issuecomment-988330183
Let's merge like this for now. If there is a solution for https://github.com/quarkusio/quarkus/issues/21718 that does not require `<extensions>true</extensions>`, then this commit can be reverted. Otherwise, we will probably have to add `<extensions>true</extensions>` everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #3359: Workaround for NoSuchFileException: .../target/classes when executing a
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #3359:
URL: https://github.com/apache/camel-quarkus/pull/3359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on a change in pull request #3359: Workaround for NoSuchFileException: .../target/classes when executing a
Posted by GitBox <gi...@apache.org>.
zbendhiba commented on a change in pull request #3359:
URL: https://github.com/apache/camel-quarkus/pull/3359#discussion_r764153075
##########
File path: integration-tests/avro/pom.xml
##########
@@ -62,6 +62,7 @@
<plugin>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-maven-plugin</artifactId>
+ <extensions>true</extensions><!-- Workaround for https://github.com/quarkusio/quarkus/issues/21718 -->
Review comment:
What is the default version of extensions ? Why we don't have a value for it ?
On the doc here, it seems to be set to true on each snippet of code.
I'm trying to understand. Otherwise, LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #3359: Workaround for NoSuchFileException: .../target/classes when executing a
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #3359:
URL: https://github.com/apache/camel-quarkus/pull/3359#discussion_r764344277
##########
File path: integration-tests/avro/pom.xml
##########
@@ -62,6 +62,7 @@
<plugin>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-maven-plugin</artifactId>
+ <extensions>true</extensions><!-- Workaround for https://github.com/quarkusio/quarkus/issues/21718 -->
Review comment:
> What is the default version of extensions ?
`false`
> Why we don't have a value for it ?
`true` is only needed if a plugin should act as Maven extension - i.e. have access to more Maven APIs than usual plugins.
Here I am trying to eliminate the failure of second `mvnd` invocation, that happens only with projects where we invoke `quarkus-maven-plugin` 's `generate-code` goal. Without `<extensions>true</extensions>` some cache inside `quarkus-maven-plugin` does not get cleared via `AbstractMavenLifecycleParticipant`, because `AbstractMavenLifecycleParticipant` are only honored in Maven extensions.
This helps to get rid of the failure, but it is still a good question whether the plugin works correctly in the rest of the test modules (even though it does not fail there).
WDYT @aloubyansky do we need to have `<extensions>true</extensions>` also in test modules where second mvnd invocation does not fail? - i.e. does the `build` mojo assume/require a fresh bootstrap on every maven invocation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org