You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@gump.apache.org by Konstantin Kolinko <kn...@gmail.com> on 2017/12/14 13:18:44 UTC
Re: svn commit: r1817993 - /gump/metadata/project/tomcat-trunk.xml
Hi, Mark!
To dev@tomcat, cc: general@gump.
The result of this change is that Gump building Tomcat downloads
tar.gz for Commons-Daemon from mirrors.
The logs [1]:
[[[
trydownload:
[get] Getting:
http://www.apache.org/dyn/closer.lua?action=download&filename=/commons/daemon/source/commons-daemon-1.1.0-native-src.tar.gz
[get] To:
/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs/download-1488937973.tmp
[get] http://www.apache.org/dyn/closer.lua?action=download&filename=/commons/daemon/source/commons-daemon-1.1.0-native-src.tar.gz
moved to http://mirror.novg.net/apache//commons/daemon/source/commons-daemon-1.1.0-native-src.tar.gz
]]]
Configuration of Commons-Daemon at Gump was changed in r1817886 [2]
Looking at pom.xml of commons-daemon, [3]
I see that it declares configuration for maven-assembly-plugin that
packs the src.tar.gz file,
but looking into Gump run logs for commons-daemon, I do not see
src.tar.gz file being built at all:
http://vmgump-vm3.apache.org/apache-commons/commons-daemon/gump_work/build_apache-commons_commons-daemon.html
The "mvn package" command used by Gump does not build the src.tar.gz file.
The file can be built by "mvn assembly:single" command, [4]
but HOWTO-RELEASE.txt file does not mention it so I wonder what is
actually used by Commons Daemon here.
So this can be fixed by updating Gump configuration for commons-daemon to do
<mvn3 goal="assembly:single" /> and
<jar name="daemon/target/commons-daemon-[0-9]*[0-9T]-native-src.tar.gz"
id="native-distro" />
Alternatively, a question is whether the "deploy" target in Tomcat
actually has a need to copy the *.tar.gz files to CATALINA_HOME/bin/.
Those source file are needed when redistributing Tomcat, but they are
not actually needed when running it.
[1] http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk/gump_work/build_tomcat-trunk_tomcat-trunk.html
[2] http://svn.apache.org/viewvc?view=revision&revision=1817886
[3] http://svn.apache.org/viewvc/commons/proper/daemon/trunk/pom.xml?revision=1816118&view=markup
[4] http://maven.apache.org/plugins/maven-assembly-plugin/
2017-12-13 12:43 GMT+03:00 <ma...@apache.org>:
> Author: markt
> Date: Wed Dec 13 09:43:40 2017
> New Revision: 1817993
>
> URL: http://svn.apache.org/viewvc?rev=1817993&view=rev
> Log:
> Remove unused (and in one case incorrect) property settings for Tomcat 9
>
> Modified:
> gump/metadata/project/tomcat-trunk.xml
>
> Modified: gump/metadata/project/tomcat-trunk.xml
> URL: http://svn.apache.org/viewvc/gump/metadata/project/tomcat-trunk.xml?rev=1817993&r1=1817992&r2=1817993&view=diff
> ==============================================================================
> --- gump/metadata/project/tomcat-trunk.xml (original)
> +++ gump/metadata/project/tomcat-trunk.xml Wed Dec 13 09:43:40 2017
> @@ -34,10 +34,6 @@
> <depend property="jdt.jar" project="eclipse" id="jdtcore" />
> <depend property="commons-daemon.jar" project="commons-daemon"
> id="commons-daemon" />
> - <property name="commons-daemon.native.src.tgz" project="commons-daemon"
> - id="native-distro" reference="outputpath" />
> - <property name="tomcat-native.tar.gz" project="commons-daemon"
> - id="native-distro" reference="outputpath" />
> <property name="junit.jar" project="junit" reference="jarpath" id="junit" />
> <property name="base.path" path="tomcat-build-libs"/>
> </ant>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org
Re: svn commit: r1817993 - /gump/metadata/project/tomcat-trunk.xml
Posted by sebb <se...@gmail.com>.
On 14 December 2017 at 15:20, Mark Thomas <ma...@apache.org> wrote:
> On 14/12/17 13:18, Konstantin Kolinko wrote:
>> Hi, Mark!
>>
>> To dev@tomcat, cc: general@gump.
>>
>>
>> The result of this change is that Gump building Tomcat downloads
>> tar.gz for Commons-Daemon from mirrors.
>
> Drat. That wasn't the intention at all.
>
> <snip/>
>
>> The "mvn package" command used by Gump does not build the src.tar.gz file.
>>
>> The file can be built by "mvn assembly:single" command, [4]
>> but HOWTO-RELEASE.txt file does not mention it so I wonder what is
>> actually used by Commons Daemon here.
>
> The command 'mvn deploy -Prelease' creates it. I suspect that isn't
> appropriate for Gump.
FTR:
You can add the following options to deploy to target/deploy and not
sign the artifacts:
-Ptest-deploy -Dgpg.skip
Documented here:
http://commons.apache.org/releases/prepare.html#Create_the_Release_Candidate
>> So this can be fixed by updating Gump configuration for commons-daemon to do
>> <mvn3 goal="assembly:single" /> and
>> <jar name="daemon/target/commons-daemon-[0-9]*[0-9T]-native-src.tar.gz"
>> id="native-distro" />
>>
>>
>> Alternatively, a question is whether the "deploy" target in Tomcat
>> actually has a need to copy the *.tar.gz files to CATALINA_HOME/bin/.
>> Those source file are needed when redistributing Tomcat, but they are
>> not actually needed when running it.
>
> Good point.
>
> The Windows binaries are only copied to /bin for the dist-static target.
> I can't see a reason not to treat the *.tar.gz src files the same way.
>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
> For additional commands, e-mail: general-help@gump.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1817993 - /gump/metadata/project/tomcat-trunk.xml
Posted by sebb <se...@gmail.com>.
On 14 December 2017 at 15:20, Mark Thomas <ma...@apache.org> wrote:
> On 14/12/17 13:18, Konstantin Kolinko wrote:
>> Hi, Mark!
>>
>> To dev@tomcat, cc: general@gump.
>>
>>
>> The result of this change is that Gump building Tomcat downloads
>> tar.gz for Commons-Daemon from mirrors.
>
> Drat. That wasn't the intention at all.
>
> <snip/>
>
>> The "mvn package" command used by Gump does not build the src.tar.gz file.
>>
>> The file can be built by "mvn assembly:single" command, [4]
>> but HOWTO-RELEASE.txt file does not mention it so I wonder what is
>> actually used by Commons Daemon here.
>
> The command 'mvn deploy -Prelease' creates it. I suspect that isn't
> appropriate for Gump.
FTR:
You can add the following options to deploy to target/deploy and not
sign the artifacts:
-Ptest-deploy -Dgpg.skip
Documented here:
http://commons.apache.org/releases/prepare.html#Create_the_Release_Candidate
>> So this can be fixed by updating Gump configuration for commons-daemon to do
>> <mvn3 goal="assembly:single" /> and
>> <jar name="daemon/target/commons-daemon-[0-9]*[0-9T]-native-src.tar.gz"
>> id="native-distro" />
>>
>>
>> Alternatively, a question is whether the "deploy" target in Tomcat
>> actually has a need to copy the *.tar.gz files to CATALINA_HOME/bin/.
>> Those source file are needed when redistributing Tomcat, but they are
>> not actually needed when running it.
>
> Good point.
>
> The Windows binaries are only copied to /bin for the dist-static target.
> I can't see a reason not to treat the *.tar.gz src files the same way.
>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
> For additional commands, e-mail: general-help@gump.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org
Re: svn commit: r1817993 - /gump/metadata/project/tomcat-trunk.xml
Posted by Mark Thomas <ma...@apache.org>.
On 14/12/17 13:18, Konstantin Kolinko wrote:
> Hi, Mark!
>
> To dev@tomcat, cc: general@gump.
>
>
> The result of this change is that Gump building Tomcat downloads
> tar.gz for Commons-Daemon from mirrors.
Drat. That wasn't the intention at all.
<snip/>
> The "mvn package" command used by Gump does not build the src.tar.gz file.
>
> The file can be built by "mvn assembly:single" command, [4]
> but HOWTO-RELEASE.txt file does not mention it so I wonder what is
> actually used by Commons Daemon here.
The command 'mvn deploy -Prelease' creates it. I suspect that isn't
appropriate for Gump.
> So this can be fixed by updating Gump configuration for commons-daemon to do
> <mvn3 goal="assembly:single" /> and
> <jar name="daemon/target/commons-daemon-[0-9]*[0-9T]-native-src.tar.gz"
> id="native-distro" />
>
>
> Alternatively, a question is whether the "deploy" target in Tomcat
> actually has a need to copy the *.tar.gz files to CATALINA_HOME/bin/.
> Those source file are needed when redistributing Tomcat, but they are
> not actually needed when running it.
Good point.
The Windows binaries are only copied to /bin for the dist-static target.
I can't see a reason not to treat the *.tar.gz src files the same way.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org
Re: svn commit: r1817993 - /gump/metadata/project/tomcat-trunk.xml
Posted by Stefan Bodewig <bo...@apache.org>.
On 2017-12-14, Konstantin Kolinko wrote:
> Configuration of Commons-Daemon at Gump was changed in r1817886 [2]
Yes, I did as the Ant build Gump used before has been removed.
> The file can be built by "mvn assembly:single" command, [4]
> but HOWTO-RELEASE.txt file does not mention it so I wonder what is
> actually used by Commons Daemon here.
I didn't see how it was built and am clueless enough when it comes to
mvn that I didn't think about assembly:single.
> <mvn3 goal="assembly:single" /> and
> <jar name="daemon/target/commons-daemon-[0-9]*[0-9T]-native-src.tar.gz"
> id="native-distro" />
+1
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org
Re: svn commit: r1817993 - /gump/metadata/project/tomcat-trunk.xml
Posted by Stefan Bodewig <bo...@apache.org>.
On 2017-12-14, Konstantin Kolinko wrote:
> Configuration of Commons-Daemon at Gump was changed in r1817886 [2]
Yes, I did as the Ant build Gump used before has been removed.
> The file can be built by "mvn assembly:single" command, [4]
> but HOWTO-RELEASE.txt file does not mention it so I wonder what is
> actually used by Commons Daemon here.
I didn't see how it was built and am clueless enough when it comes to
mvn that I didn't think about assembly:single.
> <mvn3 goal="assembly:single" /> and
> <jar name="daemon/target/commons-daemon-[0-9]*[0-9T]-native-src.tar.gz"
> id="native-distro" />
+1
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1817993 - /gump/metadata/project/tomcat-trunk.xml
Posted by Mark Thomas <ma...@apache.org>.
On 14/12/17 13:18, Konstantin Kolinko wrote:
> Hi, Mark!
>
> To dev@tomcat, cc: general@gump.
>
>
> The result of this change is that Gump building Tomcat downloads
> tar.gz for Commons-Daemon from mirrors.
Drat. That wasn't the intention at all.
<snip/>
> The "mvn package" command used by Gump does not build the src.tar.gz file.
>
> The file can be built by "mvn assembly:single" command, [4]
> but HOWTO-RELEASE.txt file does not mention it so I wonder what is
> actually used by Commons Daemon here.
The command 'mvn deploy -Prelease' creates it. I suspect that isn't
appropriate for Gump.
> So this can be fixed by updating Gump configuration for commons-daemon to do
> <mvn3 goal="assembly:single" /> and
> <jar name="daemon/target/commons-daemon-[0-9]*[0-9T]-native-src.tar.gz"
> id="native-distro" />
>
>
> Alternatively, a question is whether the "deploy" target in Tomcat
> actually has a need to copy the *.tar.gz files to CATALINA_HOME/bin/.
> Those source file are needed when redistributing Tomcat, but they are
> not actually needed when running it.
Good point.
The Windows binaries are only copied to /bin for the dist-static target.
I can't see a reason not to treat the *.tar.gz src files the same way.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org