[GitHub] [spark] vanzin opened a new pull request #26058: [SPARK-10614][core] Add monotonic time to Clock interface.

[GitBox <gi...@apache.org>]

vanzin opened a new pull request #26058: [SPARK-10614][core] Add monotonic time to Clock interface.
URL: https://github.com/apache/spark/pull/26058
 
 
   This change adds a new method to the Clock interface that returns
   the time from a monotonic time source, so that code that needs that
   feature can also mock the Clock in tests.
   
   The original getTimeMillis and waitTillTime methods are unchanged, since
   streaming code that uses the Clock interface seems to rely on wall clock
   semantics, not monotonic clock. So, in a way, this doesn't directly
   address the problem raised in the bug, that waitTillTime can be affected
   by drift, but then the places being modified to use the new API don't
   really rely on that API.
   
   The dynamic allocation code was modified to use the new time source,
   since they shouldn't be basing their decisions on wall clock time.
   
   Tested with unit test and also running apps with dynamic allocation on.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org