You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/01/15 22:12:15 UTC
[GitHub] [mynewt-core] vrahane opened a new pull request #2157: sys/log:
Remove support for LOG_VERSION 2
vrahane opened a new pull request #2157: sys/log: Remove support for LOG_VERSION 2
URL: https://github.com/apache/mynewt-core/pull/2157
This fixes #2120. If you would like to know more, please take a look at the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] vrahane merged pull request #2157: sys/log: Remove
support for LOG_VERSION 2
Posted by GitBox <gi...@apache.org>.
vrahane merged pull request #2157: sys/log: Remove support for LOG_VERSION 2
URL: https://github.com/apache/mynewt-core/pull/2157
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] vrahane commented on a change in pull request #2157:
sys/log: Remove support for LOG_VERSION 2
Posted by GitBox <gi...@apache.org>.
vrahane commented on a change in pull request #2157: sys/log: Remove support for LOG_VERSION 2
URL: https://github.com/apache/mynewt-core/pull/2157#discussion_r367178177
##########
File path: sys/log/full/pkg.yml
##########
@@ -30,20 +30,18 @@ pkg.deps:
- "@apache-mynewt-core/sys/log/common"
- "@apache-mynewt-core/util/cbmem"
-pkg.deps.'LOG_CLI && LOG_VERSION > 2':
- - "@apache-mynewt-core/sys/log/util/log_cbor_reader"
-
pkg.deps.LOG_FCB:
- "@apache-mynewt-core/hw/hal"
- "@apache-mynewt-core/fs/fcb"
pkg.deps.LOG_FCB2:
- "@apache-mynewt-core/fs/fcb2"
pkg.deps.LOG_CLI:
+ - "@apache-mynewt-core/sys/log/util/log_cbor_reader"
Review comment:
yes, this is intentional. It was
```
pkg.deps.'LOG_CLI && LOG_VERSION > 2':
- "@apache-mynewt-core/sys/log/util/log_cbor_reader"
```
which I removed above and combined it below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] ccollins476ad commented on a change in pull request
#2157: sys/log: Remove support for LOG_VERSION 2
Posted by GitBox <gi...@apache.org>.
ccollins476ad commented on a change in pull request #2157: sys/log: Remove support for LOG_VERSION 2
URL: https://github.com/apache/mynewt-core/pull/2157#discussion_r367176578
##########
File path: sys/log/full/pkg.yml
##########
@@ -30,20 +30,18 @@ pkg.deps:
- "@apache-mynewt-core/sys/log/common"
- "@apache-mynewt-core/util/cbmem"
-pkg.deps.'LOG_CLI && LOG_VERSION > 2':
- - "@apache-mynewt-core/sys/log/util/log_cbor_reader"
-
pkg.deps.LOG_FCB:
- "@apache-mynewt-core/hw/hal"
- "@apache-mynewt-core/fs/fcb"
pkg.deps.LOG_FCB2:
- "@apache-mynewt-core/fs/fcb2"
pkg.deps.LOG_CLI:
+ - "@apache-mynewt-core/sys/log/util/log_cbor_reader"
Review comment:
Was this addition intentional?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services