You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/05 16:07:01 UTC
[GitHub] [airflow] potiuk opened a new pull request #7064: [AIRFLOW-6471]
Add pytest-instafail plugin
potiuk opened a new pull request #7064: [AIRFLOW-6471] Add pytest-instafail plugin
URL: https://github.com/apache/airflow/pull/7064
We have a problem currently that if a test fails in CI we do not see the
failures immediately - only when it finishes, but when tests hang, sometimes
the details about failed tests are not shown immediately. We tried to increase
verbosity but it's not very helpful.
The pytest-instafail plugin solves the problem without increasing verbosity.
---
Link to JIRA issue: https://issues.apache.org/jira/browse/AIRFLOW-6471
- [x] Description above provides context of the change
- [x] Commit message starts with `[AIRFLOW-NNNN]`, where AIRFLOW-NNNN = JIRA ID*
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
(*) For document-only changes, no JIRA issue is needed. Commit message starts `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 commented on issue #7064: [AIRFLOW-6471] Add
pytest-instafail plugin
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on issue #7064: [AIRFLOW-6471] Add pytest-instafail plugin
URL: https://github.com/apache/airflow/pull/7064#issuecomment-570946026
@potiuk https://travis-ci.org/apache/airflow/jobs/632996416?utm_medium=notification&utm_source=github_status gave no details, just timeout
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7064: [AIRFLOW-6471] Add
pytest-instafail plugin
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7064: [AIRFLOW-6471] Add pytest-instafail plugin
URL: https://github.com/apache/airflow/pull/7064#issuecomment-570955651
It succeeded now I think!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7064: [AIRFLOW-6471] Add
pytest-instafail plugin
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7064: [AIRFLOW-6471] Add pytest-instafail plugin
URL: https://github.com/apache/airflow/pull/7064#issuecomment-570925142
This is how it will look like - no more disappearing test failures after the build times out.
<img width="1645" alt="Screenshot 2020-01-05 at 16 59 45" src="https://user-images.githubusercontent.com/595491/71782743-dcfbf880-2fdd-11ea-8034-e2043d1b7270.png">
I think it removes the need of decreasing the timeout (which can lead to some unnecessary errors when a test runs significantly longer than usual) and increasing pytest verbosity (when a test fail we will immediately see all necessary details to see what was going on).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7064: [AIRFLOW-6471] Add
pytest-instafail plugin
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7064: [AIRFLOW-6471] Add pytest-instafail plugin
URL: https://github.com/apache/airflow/pull/7064#issuecomment-570928777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7064?src=pr&el=h1) Report
> Merging [#7064](https://codecov.io/gh/apache/airflow/pull/7064?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/df2c288c6810966e0349e266cfc69a72dea11887?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7064?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7064 +/- ##
=========================================
- Coverage 84.76% 84.7% -0.07%
=========================================
Files 679 679
Lines 38647 38647
=========================================
- Hits 32761 32736 -25
- Misses 5886 5911 +25
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7064?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7064/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7064/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7064/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7064/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7064/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7064/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.59% <0%> (-0.29%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7064/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7064/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7064/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.55% <0%> (+1.53%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7064/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.66% <0%> (+6.66%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/airflow/pull/7064/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7064?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7064?src=pr&el=footer). Last update [df2c288...d35d0b6](https://codecov.io/gh/apache/airflow/pull/7064?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7064:
[AIRFLOW-6471] Add pytest-instafail plugin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7064: [AIRFLOW-6471] Add pytest-instafail plugin
URL: https://github.com/apache/airflow/pull/7064#issuecomment-570928777
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7064?src=pr&el=h1) Report
> Merging [#7064](https://codecov.io/gh/apache/airflow/pull/7064?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/df2c288c6810966e0349e266cfc69a72dea11887?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7064?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7064 +/- ##
=========================================
- Coverage 84.76% 84.7% -0.07%
=========================================
Files 679 679
Lines 38647 38647
=========================================
- Hits 32761 32736 -25
- Misses 5886 5911 +25
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7064?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7064/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7064/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7064/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7064/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7064/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7064/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.59% <0%> (-0.29%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7064/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7064/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7064/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.55% <0%> (+1.53%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7064/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.66% <0%> (+6.66%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/airflow/pull/7064/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7064?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7064?src=pr&el=footer). Last update [df2c288...d35d0b6](https://codecov.io/gh/apache/airflow/pull/7064?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7064: [AIRFLOW-6471] Add
pytest-instafail plugin
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7064: [AIRFLOW-6471] Add pytest-instafail plugin
URL: https://github.com/apache/airflow/pull/7064
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services