[jira] [Updated] (LUCENE-7560) Can we make QueryBuilder.createFieldQuery un-final?

["Michael McCandless (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-7560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless updated LUCENE-7560:
---------------------------------------
    Attachment: LUCENE-7560.patch

Patch, making private methods protected.

I also added a warning in the javadocs for {{createFieldQuery}} warning that typically you should not need to override it.

> Can we make QueryBuilder.createFieldQuery un-final?
> ---------------------------------------------------
>
>                 Key: LUCENE-7560
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7560
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>             Fix For: master (7.0), 6.4
>
>         Attachments: LUCENE-7560.patch
>
>
> It's marked final, I assume because we want people who customize their query parsers to only override {{newXXXQuery}} instead.
> But for deeper query parser customization, like using exploring consuming a graph and creating a {{TermAutomatonQuery}}, or a union of {{PhraseQuery}}, etc., it is not possible today and one must fork the class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org