You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Rahul Akolkar <ra...@gmail.com> on 2006/09/01 01:04:59 UTC
Re: [VOTE] Release Commons JEXL 1.1
Ran the usual gamut of checks, looks good to me.
<snip/>
> ---------------
> [X] +1 I support this release
> [ ] +0
> [ ] -0
> [ ] -1 I oppose this release because...
> ----------------
>
<snap/>
-Rahul
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Release Commons JEXL 1.1
Posted by Martin van den Bemt <ml...@mvdb.net>.
I'll check it this weekend :)
Mvgr,
Martin
Rahul Akolkar wrote:
> Ran the usual gamut of checks, looks good to me.
>
> <snip/>
>> ---------------
>> [X] +1 I support this release
>> [ ] +0
>> [ ] -0
>> [ ] -1 I oppose this release because...
>> ----------------
>>
> <snap/>
>
> -Rahul
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Release Commons JEXL 1.1
Posted by Dion Gillard <di...@gmail.com>.
+1.
On 9/1/06, Rahul Akolkar <ra...@gmail.com> wrote:
> Ran the usual gamut of checks, looks good to me.
>
> <snip/>
> > ---------------
> > [X] +1 I support this release
> > [ ] +0
> > [ ] -0
> > [ ] -1 I oppose this release because...
> > ----------------
> >
> <snap/>
>
> -Rahul
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
--
http://www.multitask.com.au/people/dion/
"If you even dream of beating me you'd better wake up and apologize" -
Muhammad Ali
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Release Commons JEXL 1.1
Posted by Paul Libbrecht <pa...@activemath.org>.
Just my 2p: if I remember well, there's a way checkstyle errors can
produce a text-like report with <filename>:line-number:message which is
exactly what most compilers would output to make errors clickable in,
say, jEdit and Emacs to name a few... That helped me every time i was
haunted by the checkstyle reports...
paul
Dion Gillard wrote:
> Rahul,
>
> I'll start looking at the checkstyle config and issues if you're happy
> with that?
>
> On 9/4/06, Phil Steitz <ph...@gmail.com> wrote:
>> Looks good to me. +1 assuming build has been tested on 1.2, which is
>> what the jar manifest specifies.
>>
>> One small nit, which you could do without another RC, IMO, or ignore:
>>
>> The checkstyle report is not clean. One real javadoc error is
>> flagged, some missing javadoc, missing package javadoc for a couple of
>> packages, and some bogus complaints. I would recommend either fixing
>> all of the errors, modifying checkstyle.xml, or dropping the report
>> from the doc included in the distribution.
>>
>> Phil
>>
>> On 8/31/06, Rahul Akolkar <ra...@gmail.com> wrote:
>> > Ran the usual gamut of checks, looks good to me.
>> >
>> > <snip/>
>> > > ---------------
>> > > [X] +1 I support this release
>> > > [ ] +0
>> > > [ ] -0
>> > > [ ] -1 I oppose this release because...
>> > > ----------------
>> > >
>> > <snap/>
>> >
>> > -Rahul
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>> > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>> >
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>>
>>
>
>
Re: [VOTE] Release Commons JEXL 1.1
Posted by Rahul Akolkar <ra...@gmail.com>.
On 9/6/06, Jörg Schaible <jo...@gmx.de> wrote:
<snip/>
>
> Site:
>
> - site/index.html: the menu has as second item a reference to javadoc-1.0,
> which should be now 1.1 (and is a dead-link anyway)
> - site/index.html: the link in the menu to the examples should better point
> to the viewcvs.cgi version (see links on site/cvs-usage.html
> for "subversion viewer")
> - site/index.html: "Releases" section references 1.0 only
> - site/index.html: typo "compatibile"
> - site/releases.html: references 1.0 only
> - site/downloads.html: references 1.0 only (you might have to add the
> version to versions section of the project.xml)
> - site/javadoc.html: The output shows two invalid javadoc links
>
<snap/>
Thanks for the detailed feedback, I had planned to update the 1.1
release bits on the site as part of cutting the release. As a
procedural question, I wasn't sure whether a site should talk about
the next release before that vote has actually passed.
I've corrected the typo and changed examples to the viewcvs link. Thanks!
> Files:
> - the *.tar.gz files show following message unpacking it: "tar: A lone zero
> block at xxxx" (Linux)
>
<snip/>
Seems this ant issue has the details:
http://issues.apache.org/bugzilla/show_bug.cgi?id=28776
Did that cause any other problems in the actual untarring?
-Rahul
> Bascially I am +1 to a release, but the site docs should at least be
> up-to-date for 1.1 at the relevant places.
>
> - Jörg
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Release Commons JEXL 1.1
Posted by Jörg Schaible <jo...@gmx.de>.
Rahul Akolkar wrote:
> On 9/6/06, Phil Steitz <ph...@gmail.com> wrote:
>> On 9/5/06, Dion Gillard <di...@gmail.com> wrote:
> <snip/>
>> >
>> > I'm happy for the checkstyle report/config to be fixed post 1.1
>> > release.
>> >
>> I don't see this as showstopper either - as stated above, I am +1 with
>> release as is and understand Rahu's reservation about changes after RC
>> tag and vote.
>>
> <snap/>
>
> Thanks Dion, Phil for clarifying.
>
> As a reminder, this vote closes in half a day.
>
> -Rahul
>
>
>> Phil
>>
Site:
- site/index.html: the menu has as second item a reference to javadoc-1.0,
which should be now 1.1 (and is a dead-link anyway)
- site/index.html: the link in the menu to the examples should better point
to the viewcvs.cgi version (see links on site/cvs-usage.html
for "subversion viewer")
- site/index.html: "Releases" section references 1.0 only
- site/index.html: typo "compatibile"
- site/releases.html: references 1.0 only
- site/downloads.html: references 1.0 only (you might have to add the
version to versions section of the project.xml)
- site/javadoc.html: The output shows two invalid javadoc links
Files:
- the *.tar.gz files show following message unpacking it: "tar: A lone zero
block at xxxx" (Linux)
Bascially I am +1 to a release, but the site docs should at least be
up-to-date for 1.1 at the relevant places.
- Jörg
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Release Commons JEXL 1.1
Posted by Rahul Akolkar <ra...@gmail.com>.
On 9/6/06, Phil Steitz <ph...@gmail.com> wrote:
> On 9/5/06, Dion Gillard <di...@gmail.com> wrote:
<snip/>
> >
> > I'm happy for the checkstyle report/config to be fixed post 1.1 release.
> >
> I don't see this as showstopper either - as stated above, I am +1 with
> release as is and understand Rahu's reservation about changes after RC
> tag and vote.
>
<snap/>
Thanks Dion, Phil for clarifying.
As a reminder, this vote closes in half a day.
-Rahul
> Phil
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Release Commons JEXL 1.1
Posted by Phil Steitz <ph...@gmail.com>.
On 9/5/06, Dion Gillard <di...@gmail.com> wrote:
> On 9/6/06, Rahul Akolkar <ra...@gmail.com> wrote:
> <snip/>
>
> > Phil is correct in pointing out that they be fixed, but IMO, which
> > side of 1.1 that happens on is secondary -- as long as it happens.
> > Doing it later gives us a clean process now (ideally, no mods between
> > voting and a release, and though we have practical considerations, not
> > sure we should exercise those in this case). Ofcourse, if I'm the only
> > one who thinks that way, please go ahead ;-)
>
> I'm happy for the checkstyle report/config to be fixed post 1.1 release.
>
I don't see this as showstopper either - as stated above, I am +1 with
release as is and understand Rahu's reservation about changes after RC
tag and vote.
Phil
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Release Commons JEXL 1.1
Posted by Dion Gillard <di...@gmail.com>.
On 9/6/06, Rahul Akolkar <ra...@gmail.com> wrote:
<snip/>
> Phil is correct in pointing out that they be fixed, but IMO, which
> side of 1.1 that happens on is secondary -- as long as it happens.
> Doing it later gives us a clean process now (ideally, no mods between
> voting and a release, and though we have practical considerations, not
> sure we should exercise those in this case). Ofcourse, if I'm the only
> one who thinks that way, please go ahead ;-)
I'm happy for the checkstyle report/config to be fixed post 1.1 release.
--
http://www.multitask.com.au/people/dion/
Rule of Acquisition #91: Hear all, trust nothing.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Release Commons JEXL 1.1
Posted by Rahul Akolkar <ra...@gmail.com>.
Thanks to everyone's feedback so far. Sorry, I was away over the
weekend, couldn't reply sooner. Consolidating couple of replies in
one:
On 9/3/06, Phil Steitz <ph...@gmail.com> wrote:
> Looks good to me. +1 assuming build has been tested on 1.2, which is
> what the jar manifest specifies.
>
<snip/>
The necessary compiler source/target settings are set at 1.2, however
we discussed [1] that a 1.3 build would be acceptable before we went
down this route. In any case, if anyone has 1.2 lying around (I don't)
and wants to do any testing, we can extend this vote for another
couple of days. Please let me know.
[1] http://marc.theaimsgroup.com/?l=jakarta-commons-dev&m=115500076427917&w=2
> One small nit, which you could do without another RC, IMO, or ignore:
>
> The checkstyle report is not clean. One real javadoc error is
> flagged, some missing javadoc, missing package javadoc for a couple of
> packages, and some bogus complaints. I would recommend either fixing
> all of the errors, modifying checkstyle.xml, or dropping the report
> from the doc included in the distribution.
>
> Phil
>
<snap/>
On 9/4/06, Dion Gillard <di...@gmail.com> wrote:
> Rahul,
>
> I'll start looking at the checkstyle config and issues if you're happy
> with that?
>
<snip/>
Phil is correct in pointing out that they be fixed, but IMO, which
side of 1.1 that happens on is secondary -- as long as it happens.
Doing it later gives us a clean process now (ideally, no mods between
voting and a release, and though we have practical considerations, not
sure we should exercise those in this case). Ofcourse, if I'm the only
one who thinks that way, please go ahead ;-)
-Rahul
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Release Commons JEXL 1.1
Posted by Dion Gillard <di...@gmail.com>.
Rahul,
I'll start looking at the checkstyle config and issues if you're happy
with that?
On 9/4/06, Phil Steitz <ph...@gmail.com> wrote:
> Looks good to me. +1 assuming build has been tested on 1.2, which is
> what the jar manifest specifies.
>
> One small nit, which you could do without another RC, IMO, or ignore:
>
> The checkstyle report is not clean. One real javadoc error is
> flagged, some missing javadoc, missing package javadoc for a couple of
> packages, and some bogus complaints. I would recommend either fixing
> all of the errors, modifying checkstyle.xml, or dropping the report
> from the doc included in the distribution.
>
> Phil
>
> On 8/31/06, Rahul Akolkar <ra...@gmail.com> wrote:
> > Ran the usual gamut of checks, looks good to me.
> >
> > <snip/>
> > > ---------------
> > > [X] +1 I support this release
> > > [ ] +0
> > > [ ] -0
> > > [ ] -1 I oppose this release because...
> > > ----------------
> > >
> > <snap/>
> >
> > -Rahul
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
--
http://www.multitask.com.au/people/dion/
Rule #91: Hear all, trust nothing.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [VOTE] Release Commons JEXL 1.1
Posted by Phil Steitz <ph...@gmail.com>.
Looks good to me. +1 assuming build has been tested on 1.2, which is
what the jar manifest specifies.
One small nit, which you could do without another RC, IMO, or ignore:
The checkstyle report is not clean. One real javadoc error is
flagged, some missing javadoc, missing package javadoc for a couple of
packages, and some bogus complaints. I would recommend either fixing
all of the errors, modifying checkstyle.xml, or dropping the report
from the doc included in the distribution.
Phil
On 8/31/06, Rahul Akolkar <ra...@gmail.com> wrote:
> Ran the usual gamut of checks, looks good to me.
>
> <snip/>
> > ---------------
> > [X] +1 I support this release
> > [ ] +0
> > [ ] -0
> > [ ] -1 I oppose this release because...
> > ----------------
> >
> <snap/>
>
> -Rahul
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org