[jira] [Commented] (ZOOKEEPER-1336) javadoc for multi is confusing, references functionality that doesn't seem to exist

["Hadoop QA (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201116#comment-13201116 ] 

Hadoop QA commented on ZOOKEEPER-1336:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12508418/ZOOKEEPER-1336.patch
  against trunk revision 1238176.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/944//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/944//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/944//console

This message is automatically generated.
                
> javadoc for multi is confusing, references functionality that doesn't seem to exist 
> ------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1336
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1336
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.4.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.4.3, 3.5.0
>
>         Attachments: ZOOKEEPER-1336.patch
>
>
> There's this in org.apache.zookeeper.ZooKeeper.multi(Iterable<Op>)
> {noformat}
>      * Executes multiple Zookeeper operations or none of them.  On success, a list of results is returned.
>      * On failure, only a single exception is returned.  If you want more details, it may be preferable to
>      * use the alternative form of this method that lets you pass a list into which individual results are
>      * placed so that you can zero in on exactly which operation failed and why.
> {noformat}
> What is the "alternate form of this method" that's being referred to? Seems like we should add this functionality, or at the very least update the javadoc. (I don't think this is referring to Transaction, although the docs there are pretty thin)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira