You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/11/15 09:33:42 UTC
[GitHub] [geode] ruanwenjun opened a new pull request, #7869: Fix compile error in jdk11 due to toArray confusion
ruanwenjun opened a new pull request, #7869:
URL: https://github.com/apache/geode/pull/7869
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
When I compile with jdk11, I got an error below:
<img width="1382" alt="image" src="https://user-images.githubusercontent.com/22415594/201882997-2f20030f-132d-44c7-b81e-83f0f671af09.png">
This is caused by we have two `toArray` in `PartitionedRegion`,
one is
```
public Object[] toArray(Object[] array)
```
other is from `Collection` which is introduced in jdk 11.
```java
default <T> T[] toArray(IntFunction<T[]> generator) {
return toArray(generator.apply(0));
}
```
This PR aims to fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] ruanwenjun commented on pull request #7869: Fix compile error in jdk11 due to toArray confusion
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #7869:
URL: https://github.com/apache/geode/pull/7869#issuecomment-1323562848
> @ruanwenjun as of now Geode is compiled using JDK8, while many users run geode using 8, 11 and 17
Yes, does `Geode` plan to support compiled on JDK11 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] CalvinKirs commented on pull request #7869: Fix compile error in jdk11 due to toArray confusion
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #7869:
URL: https://github.com/apache/geode/pull/7869#issuecomment-1325917512
>
According to the OpenJDK website: https://adoptopenjdk.net/support.html
there are 3 TLS versions for now
So, I think we should make a plan to support compiled on JDK11 and 17. hi, @sboorlagadda WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] CalvinKirs merged pull request #7869: Fix compile error in jdk11 due to toArray confusion
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs merged PR #7869:
URL: https://github.com/apache/geode/pull/7869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sboorlagadda commented on pull request #7869: Fix compile error in jdk11 due to toArray confusion
Posted by "sboorlagadda (via GitHub)" <gi...@apache.org>.
sboorlagadda commented on PR #7869:
URL: https://github.com/apache/geode/pull/7869#issuecomment-1399628162
Yes. we should start building using JDK 11. But I would prefer we first spin up our pipelines before we make any code changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sboorlagadda commented on pull request #7869: Fix compile error in jdk11 due to toArray confusion
Posted by GitBox <gi...@apache.org>.
sboorlagadda commented on PR #7869:
URL: https://github.com/apache/geode/pull/7869#issuecomment-1322246666
@ruanwenjun as of now Geode is compiled using JDK8, while many users run geode using 8, 11 and 17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org