[GitHub] [airflow] chethanuk-plutoflume commented on a diff in pull request #25205: Convert RDS Export Sample DAG to System Test (AIP-47)

[GitBox <gi...@apache.org>]

chethanuk-plutoflume commented on code in PR #25205:
URL: https://github.com/apache/airflow/pull/25205#discussion_r926085850


##########
airflow/providers/amazon/aws/operators/rds.py:
##########
@@ -152,25 +155,27 @@ def execute(self, context: 'Context') -> str:
                 Tags=self.tags,
             )
             create_response = json.dumps(create_instance_snap, default=str)
-            self._await_status(
-                'instance_snapshot',
-                self.db_snapshot_identifier,
-                wait_statuses=['creating'],
-                ok_statuses=['available'],
-            )
+            if self.wait_for_completion:
+                self._await_status(
+                    'instance_snapshot',
+                    self.db_snapshot_identifier,
+                    wait_statuses=['creating'],
+                    ok_statuses=['available'],
+                )
         else:
             create_cluster_snap = self.hook.conn.create_db_cluster_snapshot(
                 DBClusterIdentifier=self.db_identifier,
                 DBClusterSnapshotIdentifier=self.db_snapshot_identifier,
                 Tags=self.tags,
             )
             create_response = json.dumps(create_cluster_snap, default=str)
-            self._await_status(
-                'cluster_snapshot',
-                self.db_snapshot_identifier,
-                wait_statuses=['creating'],
-                ok_statuses=['available'],
-            )
+            if self.wait_for_completion:

Review Comment:
   Instead of duplicating may be move this outside if [to line 179]?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org