You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/01/18 17:50:29 UTC

[GitHub] wujimin commented on a change in pull request #519: [SCB-256] fix bug: SC 0.5 is not compatible to 0.4, change sdk to suppo?

wujimin commented on a change in pull request #519: [SCB-256] fix bug: SC 0.5 is not compatible to 0.4, change sdk to suppo?
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/519#discussion_r162419485
 
 

 ##########
 File path: service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/http/ServiceRegistryClientImpl.java
 ##########
 @@ -259,7 +275,7 @@ public boolean isSchemaExist(String microserviceId, String schemaId) {
           schemaId,
           e);
     }
-    return holder.value != null;
+    return holder.value != null && schemaId.equals(holder.value.getServiceId());
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services