You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by Myasuka <gi...@git.apache.org> on 2018/05/10 09:55:22 UTC

[GitHub] flink pull request #5984: [FLINK-9328][state] Fix RocksDBStateBackend restor...

GitHub user Myasuka opened a pull request:

    https://github.com/apache/flink/pull/5984

    [FLINK-9328][state] Fix RocksDBStateBackend restore problem due to StateBackendTestBase not registering snapshots

    
    ## What is the purpose of the change
    
    Currently, StateBackendTestBase class does not register snapshots to SharedStateRegistry in testValueState, testListState, testReducingState, testFoldingState and testMapState UTs, which may cause RocksDBStateBackend to restore from PlaceholderStreamStateHandle during the 2nd restore procedure if one specific sst file both existed in the 1st snapshot and the 2nd snapshot handle.
    
    
    ## Brief change log
    
    Add sharedStateRegistry and register each snapshot to it.
    
    ## Verifying this change
    
    This change fix UT problem.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Myasuka/flink fix-StateBackendTestBase-FLINK-9328

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5984.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5984
    
----
commit a2aed70803a99124d63156a5e5146f6fff1ee83d
Author: Myasuka <my...@...>
Date:   2018-05-10T09:48:53Z

    [FLINK-9328][state] Fix RocksDBStateBackend restore problem due to StateBackendTestBase not registering snapshots

----


---

[GitHub] flink issue #5984: [FLINK-9328][state] Fix RocksDBStateBackend restore probl...

Posted by Myasuka <gi...@git.apache.org>.

Github user Myasuka commented on the issue:

    https://github.com/apache/flink/pull/5984
  
    The failing UT JobManagerFailsITCase in [#25170.9-build](https://travis-ci.org/apache/flink/jobs/393258719) is not related with this PR, shall I re-trigger the CI process?


---

[GitHub] flink issue #5984: [FLINK-9328][state] Fix RocksDBStateBackend restore probl...

Posted by Myasuka <gi...@git.apache.org>.

Github user Myasuka commented on the issue:

    https://github.com/apache/flink/pull/5984
  
    Sorry for the late reply, @tzulitai I have already rebased on the latest master now.


---

[GitHub] flink issue #5984: [FLINK-9328][state] Fix RocksDBStateBackend restore probl...

Posted by tzulitai <gi...@git.apache.org>.

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/5984
  
    Hi @Myasuka, it seems like your local branch is not properly rebased on the latest master.
    Could you try rebasing again and reopening the PR?


---