You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/22 04:01:25 UTC
[GitHub] [flink] godfreyhe opened a new pull request #14454: [FLINK-20705][table-planner-blink] Separate the implementation of BatchExecValues and StreamExecValues
godfreyhe opened a new pull request #14454:
URL: https://github.com/apache/flink/pull/14454
## What is the purpose of the change
*Separate the implementation of BatchExecValues and StreamExecValues*
## Brief change log
- *Introduce StreamPhysicalValues, and make StreamExecValues only extended from ExecNode*
- *Introduce BatchPhysicalValues, and make BatchExecValues only extended from ExecNode*
## Verifying this change
This change is a refactoring rework covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14454: [FLINK-20705][table-planner-blink] Separate the implementation of BatchExecValues and StreamExecValues
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14454:
URL: https://github.com/apache/flink/pull/14454#issuecomment-749330771
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0a6eca2a7394dd92dd8a0d7d6fd44134a9452780",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a6eca2a7394dd92dd8a0d7d6fd44134a9452780",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0a6eca2a7394dd92dd8a0d7d6fd44134a9452780 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe closed pull request #14454: [FLINK-20705][table-planner-blink] Separate the implementation of BatchExecValues and StreamExecValues
Posted by GitBox <gi...@apache.org>.
godfreyhe closed pull request #14454:
URL: https://github.com/apache/flink/pull/14454
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14454: [FLINK-20705][table-planner-blink] Separate the implementation of BatchExecValues and StreamExecValues
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14454:
URL: https://github.com/apache/flink/pull/14454#issuecomment-749330771
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0a6eca2a7394dd92dd8a0d7d6fd44134a9452780",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11158",
"triggerID" : "0a6eca2a7394dd92dd8a0d7d6fd44134a9452780",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0a6eca2a7394dd92dd8a0d7d6fd44134a9452780 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11158)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14454: [FLINK-20705][table-planner-blink] Separate the implementation of BatchExecValues and StreamExecValues
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14454:
URL: https://github.com/apache/flink/pull/14454#issuecomment-749330771
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0a6eca2a7394dd92dd8a0d7d6fd44134a9452780",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11158",
"triggerID" : "0a6eca2a7394dd92dd8a0d7d6fd44134a9452780",
"triggerType" : "PUSH"
}, {
"hash" : "e76d11752afc2238f6be0506a1fe68d243963ed7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11194",
"triggerID" : "e76d11752afc2238f6be0506a1fe68d243963ed7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0a6eca2a7394dd92dd8a0d7d6fd44134a9452780 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11158)
* e76d11752afc2238f6be0506a1fe68d243963ed7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11194)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14454: [FLINK-20705][table-planner-blink] Separate the implementation of BatchExecValues and StreamExecValues
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14454:
URL: https://github.com/apache/flink/pull/14454#issuecomment-749330771
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0a6eca2a7394dd92dd8a0d7d6fd44134a9452780",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11158",
"triggerID" : "0a6eca2a7394dd92dd8a0d7d6fd44134a9452780",
"triggerType" : "PUSH"
}, {
"hash" : "e76d11752afc2238f6be0506a1fe68d243963ed7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11194",
"triggerID" : "e76d11752afc2238f6be0506a1fe68d243963ed7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e76d11752afc2238f6be0506a1fe68d243963ed7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11194)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14454: [FLINK-20705][table-planner-blink] Separate the implementation of BatchExecValues and StreamExecValues
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14454:
URL: https://github.com/apache/flink/pull/14454#issuecomment-749330771
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0a6eca2a7394dd92dd8a0d7d6fd44134a9452780",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11158",
"triggerID" : "0a6eca2a7394dd92dd8a0d7d6fd44134a9452780",
"triggerType" : "PUSH"
}, {
"hash" : "e76d11752afc2238f6be0506a1fe68d243963ed7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11194",
"triggerID" : "e76d11752afc2238f6be0506a1fe68d243963ed7",
"triggerType" : "PUSH"
}, {
"hash" : "4f26226231f0905e6121d5dba2e84820f2a01f20",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11211",
"triggerID" : "4f26226231f0905e6121d5dba2e84820f2a01f20",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e76d11752afc2238f6be0506a1fe68d243963ed7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11194)
* 4f26226231f0905e6121d5dba2e84820f2a01f20 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11211)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #14454: [FLINK-20705][table-planner-blink] Separate the implementation of BatchExecValues and StreamExecValues
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #14454:
URL: https://github.com/apache/flink/pull/14454#issuecomment-750729345
I will merge this pr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14454: [FLINK-20705][table-planner-blink] Separate the implementation of BatchExecValues and StreamExecValues
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14454:
URL: https://github.com/apache/flink/pull/14454#issuecomment-749325670
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 0a6eca2a7394dd92dd8a0d7d6fd44134a9452780 (Tue Dec 22 04:04:00 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14454: [FLINK-20705][table-planner-blink] Separate the implementation of BatchExecValues and StreamExecValues
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14454:
URL: https://github.com/apache/flink/pull/14454#issuecomment-749330771
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0a6eca2a7394dd92dd8a0d7d6fd44134a9452780",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11158",
"triggerID" : "0a6eca2a7394dd92dd8a0d7d6fd44134a9452780",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0a6eca2a7394dd92dd8a0d7d6fd44134a9452780 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11158)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14454: [FLINK-20705][table-planner-blink] Separate the implementation of BatchExecValues and StreamExecValues
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14454:
URL: https://github.com/apache/flink/pull/14454#issuecomment-749330771
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0a6eca2a7394dd92dd8a0d7d6fd44134a9452780",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11158",
"triggerID" : "0a6eca2a7394dd92dd8a0d7d6fd44134a9452780",
"triggerType" : "PUSH"
}, {
"hash" : "e76d11752afc2238f6be0506a1fe68d243963ed7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11194",
"triggerID" : "e76d11752afc2238f6be0506a1fe68d243963ed7",
"triggerType" : "PUSH"
}, {
"hash" : "4f26226231f0905e6121d5dba2e84820f2a01f20",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11211",
"triggerID" : "4f26226231f0905e6121d5dba2e84820f2a01f20",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4f26226231f0905e6121d5dba2e84820f2a01f20 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11211)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14454: [FLINK-20705][table-planner-blink] Separate the implementation of BatchExecValues and StreamExecValues
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14454:
URL: https://github.com/apache/flink/pull/14454#issuecomment-749330771
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0a6eca2a7394dd92dd8a0d7d6fd44134a9452780",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11158",
"triggerID" : "0a6eca2a7394dd92dd8a0d7d6fd44134a9452780",
"triggerType" : "PUSH"
}, {
"hash" : "e76d11752afc2238f6be0506a1fe68d243963ed7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e76d11752afc2238f6be0506a1fe68d243963ed7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0a6eca2a7394dd92dd8a0d7d6fd44134a9452780 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11158)
* e76d11752afc2238f6be0506a1fe68d243963ed7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14454: [FLINK-20705][table-planner-blink] Separate the implementation of BatchExecValues and StreamExecValues
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14454:
URL: https://github.com/apache/flink/pull/14454#issuecomment-749330771
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0a6eca2a7394dd92dd8a0d7d6fd44134a9452780",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11158",
"triggerID" : "0a6eca2a7394dd92dd8a0d7d6fd44134a9452780",
"triggerType" : "PUSH"
}, {
"hash" : "e76d11752afc2238f6be0506a1fe68d243963ed7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11194",
"triggerID" : "e76d11752afc2238f6be0506a1fe68d243963ed7",
"triggerType" : "PUSH"
}, {
"hash" : "4f26226231f0905e6121d5dba2e84820f2a01f20",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4f26226231f0905e6121d5dba2e84820f2a01f20",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e76d11752afc2238f6be0506a1fe68d243963ed7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11194)
* 4f26226231f0905e6121d5dba2e84820f2a01f20 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org