You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/09/13 02:31:32 UTC

[GitHub] [apisix-ingress-controller] AlinsRan commented on a diff in pull request #1295: chore(refactor): the translation of upstream

AlinsRan commented on code in PR #1295:
URL: https://github.com/apache/apisix-ingress-controller/pull/1295#discussion_r969082795


##########
pkg/providers/translation/upstream.go:
##########
@@ -166,10 +164,12 @@ func (t *translator) translateUpstreamV2beta3(ep *kube.Endpoint, namespace, name
 		return nil, err
 	}
 	ups.Nodes = nodes
+	ups.Name = apisixv1.ComposeUpstreamName(namespace, name, subset, port.IntVal)

Review Comment:
   I agree that the configuration should be applied instead of generating new objects.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org