You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/05/23 12:06:27 UTC
[GitHub] [incubator-inlong] woofyzhao opened a new pull request, #4323: [Bug][Manager] Fix incorrect task service node order in create-group workflow
woofyzhao opened a new pull request, #4323:
URL: https://github.com/apache/incubator-inlong/pull/4323
Fixes #4315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] woofyzhao commented on a diff in pull request #4323: [INLONG-4315][Manager] Fix incorrect task service node order in create-group workflow
Posted by GitBox <gi...@apache.org>.
woofyzhao commented on code in PR #4323:
URL: https://github.com/apache/incubator-inlong/pull/4323#discussion_r881577105
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/workflow/group/CreateGroupWorkflowDefinition.java:
##########
@@ -85,14 +85,6 @@ public WorkflowProcess defineProcess() {
initMQResourceTask.addListenerProvider(groupTaskListenerFactory);
process.addTask(initMQResourceTask);
- // init Sort resource
Review Comment:
Understood.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4323: [INLONG-4315][Manager] Fix incorrect task service node order in create-group workflow
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4323:
URL: https://github.com/apache/incubator-inlong/pull/4323#discussion_r881566889
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/workflow/group/CreateGroupWorkflowDefinition.java:
##########
@@ -85,14 +85,6 @@ public WorkflowProcess defineProcess() {
initMQResourceTask.addListenerProvider(groupTaskListenerFactory);
process.addTask(initMQResourceTask);
- // init Sort resource
Review Comment:
We need to adjust the order of creating resources to 1. MQ -> 2. Sink -> 3. Sort -> 4. Source, so as to ensure that after some links fail, data will not be collected or consumed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang merged pull request #4323: [INLONG-4315][Manager] Fix incorrect task service node order in create-group workflow
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #4323:
URL: https://github.com/apache/incubator-inlong/pull/4323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4323: [INLONG-4315][Manager] Fix incorrect task service node order in create-group workflow
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4323:
URL: https://github.com/apache/incubator-inlong/pull/4323#discussion_r881566889
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/workflow/group/CreateGroupWorkflowDefinition.java:
##########
@@ -85,14 +85,6 @@ public WorkflowProcess defineProcess() {
initMQResourceTask.addListenerProvider(groupTaskListenerFactory);
process.addTask(initMQResourceTask);
- // init Sort resource
Review Comment:
We need to adjust the order of creating resources to 1. MQ -> 2. Sink -> 3. Sort -> 4. Source, so as to ensure that after some tasks fail, data will not be collected by source or consumed by sort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4323: [INLONG-4315][Manager] Fix incorrect task service node order in create-group workflow
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4323:
URL: https://github.com/apache/incubator-inlong/pull/4323#discussion_r881566889
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/workflow/group/CreateGroupWorkflowDefinition.java:
##########
@@ -85,14 +85,6 @@ public WorkflowProcess defineProcess() {
initMQResourceTask.addListenerProvider(groupTaskListenerFactory);
process.addTask(initMQResourceTask);
- // init Sort resource
Review Comment:
We need to adjust the order of creating resources to 1. MQ -> 2. Sink -> 3. Sort -> 4. Source, so as to ensure that after some tasks fail, data will not be collected or consumed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org