You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/02 09:49:57 UTC

[GitHub] [cloudstack] davidjumani commented on a change in pull request #5395: ui: Allow searching in dropdowns

davidjumani commented on a change in pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#discussion_r700928625



##########
File path: ui/src/components/header/SamlDomainSwitcher.vue
##########
@@ -22,6 +22,11 @@
       :loading="loading"
       :defaultValue="currentAccount"
       :value="currentAccount"
+      showSearch
+      optionFilterProp="children"
+      :filterOption="(input, option) => {
+        return option.componentOptions.children[0].text.toLowerCase().indexOf(input.toLowerCase()) >= 0
+      }"

Review comment:
       I think that might involve replicating every prop used which could potentially break things. @utchoang ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org