[GitHub] [zookeeper] eolivelli commented on a change in pull request #1019: ZOOKEEPER-3464:enfore checkstyle in the zookeeper-server module and clean the package:admin and client

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #1019: ZOOKEEPER-3464:enfore checkstyle in the zookeeper-server module and clean the package:admin and client
URL: https://github.com/apache/zookeeper/pull/1019#discussion_r305775211
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -582,19 +582,20 @@
               <version>${checkstyle.version}</version>
             </dependency>
           </dependencies>
-          <configuration>
-            <configLocation>checkstyle.xml</configLocation>
-            <suppressionsLocation>checkstyleSuppressions.xml</suppressionsLocation>
-            <encoding>UTF-8</encoding>
-            <consoleOutput>true</consoleOutput>
-            <failOnViolation>true</failOnViolation>
-            <includeResources>false</includeResources>
-            <includeTestSourceDirectory>true</includeTestSourceDirectory>
-          </configuration>
           <executions>
             <execution>
               <id>checkstyle</id>
               <phase>validate</phase>
+              <configuration>
+                <configLocation>checkstyle.xml</configLocation>
 
 Review comment:
   this way you are disabling the minimal checkstyle configuration I added to prevent the presence of '@author' tags.
   As your new configuration is applied only to some limited list of packages you are implicitly disabling that check on a part of the codebase.
   
   Please  add a new   '<execution>' of the plugin with your new checkstyle.xml and checkstyleSuppressions.xml
   
   Please test manually that if you add a '@author' javadoc tag anywhere in code the PR validation fails
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services