[jira] [Commented] (ZOOKEEPER-2149) Logging of client address when socket connection established

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377142#comment-14377142 ] 

Hadoop QA commented on ZOOKEEPER-2149:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12706787/ZOOKEEPER-2149.patch
  against trunk revision 1667358.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2583//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2583//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2583//console

This message is automatically generated.

> Logging of client address when socket connection established
> ------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2149
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2149
>             Project: ZooKeeper
>          Issue Type: Improvement
>            Reporter: Hongchao Deng
>            Assignee: Hongchao Deng
>         Attachments: ZOOKEEPER-2149.patch
>
>
> When a socket connection is established, in ZooKeeperServer, it would print logs:
> "Established session 0x$(session) with negotiated timeout $(timeout) for client: $(client_hostport)"
> However, in client, it would only print the server address:
> "Socket connection established to $(server_hostport), initiating session"
> It would be nice to log client local address when socket connection established. Because clients will reconnect and ports is randomly assigned. We can better associate these addresses in this way.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)