You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/03/20 12:32:56 UTC
[GitHub] [druid] konradr opened a new pull request #9544: Updated
kafkaProperties doc to reflect current conf
konradr opened a new pull request #9544: Updated kafkaProperties doc to reflect current conf
URL: https://github.com/apache/druid/pull/9544
### Description
https://github.com/apache/druid/blob/master/extensions-core/kafka-extraction-namespace/src/main/java/org/apache/druid/query/lookup/KafkaLookupExtractorFactory.java#L369
Shows that the `bootstrap.servers` is suppose to be specified but the docs referred to old `zookeeper.connect` config that older kafka clients used.
<hr>
This PR has:
- [x] been self-reviewed.
- [x] added documentation for new or modified features or behaviors.
- [x] been tested in a test Druid cluster.
<hr>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] konradr commented on issue #9544: Updated kafkaProperties
doc to reflect current conf
Posted by GitBox <gi...@apache.org>.
konradr commented on issue #9544: Updated kafkaProperties doc to reflect current conf
URL: https://github.com/apache/druid/pull/9544#issuecomment-601677305
Since its a very small docs change I didn't create any tickets for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] konradr commented on issue #9544: Updated
kafka-extraction-namespace kafkaProperties doc to reflect current conf
Posted by GitBox <gi...@apache.org>.
konradr commented on issue #9544: Updated kafka-extraction-namespace kafkaProperties doc to reflect current conf
URL: https://github.com/apache/druid/pull/9544#issuecomment-601847328
Looking at the CI build, I don't think `"bootstrap.servers"` should be considered a spelling error?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org