[GitHub] mahendra commented on a change in pull request #6601: Refactor selenium-related methods under `utils/selenium.py`

[GitBox <gi...@apache.org>]

mahendra commented on a change in pull request #6601: Refactor selenium-related methods under `utils/selenium.py`
URL: https://github.com/apache/incubator-superset/pull/6601#discussion_r247573369
 
 

 ##########
 File path: superset/utils/selenium.py
 ##########
 @@ -0,0 +1,100 @@
+# pylint: disable=C,R,W
+import time
+
+from flask import current_app, Response, session
+from flask_login import login_user
+from retry.api import retry_call
+from selenium.common.exceptions import WebDriverException
+from selenium.webdriver import chrome, firefox
+from werkzeug.utils import parse_cookie
+
+# Time in seconds, we will wait for the page to load and render
+PAGE_RENDER_WAIT = 2
 
 Review comment:
   we may need this at 30. This is because the JS based rendering takes a while to finish. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org