You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/11/22 11:47:01 UTC

[GitHub] [ignite-3] ptupitsyn commented on a diff in pull request #1364: IGNITE-18212 GROUP BY with alias causes parsing error

ptupitsyn commented on code in PR #1364:
URL: https://github.com/apache/ignite-3/pull/1364#discussion_r1029229725


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItAggregatesTest.java:
##########
@@ -64,6 +64,18 @@ public void countOfNonNumericField() {
                 .returns(15d, 1L)
                 .check();
 
+        // same query, but grouping by alias
+        assertQuery("select salary as sal, count(name) from person group by sal order by salary")

Review Comment:
   Can we also add a test for computed column grouping?
   
   ```sql
   select (salary / 4 + 10) as sal, count(*) from person group by sal order by sal
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org