You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Tyrel Rink (Jira)" <ji...@apache.org> on 2021/01/16 18:26:00 UTC
[jira] [Updated] (ARROW-11270) [Rust] Use slices for simple array
data buffer access
[ https://issues.apache.org/jira/browse/ARROW-11270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tyrel Rink updated ARROW-11270:
-------------------------------
Description:
Using an approach similar to ARROW-10989, migrate typed array API's to use slices where they can.
This impacts the API of:
* GenericBinaryArray<>
* GenericListArray<>
* GenericStringArray<>
This also enables bounds checking in every value() function on each of the above arrays (as well as PrimitiveArray<> ).
The new PrimitiveArray.value() bounds check has a negative performance impact on various benchmarks that still use the .Value(...) function on PrimitiveArray. But that should be resolvable by using the PrimitiveArray.values() instead (whether within this PR or a future PR).
was:
Using an approach similar to ARROW-10989, migrate typed array API's to use slices where they can.
This impacts the API of:
* GenericBinaryArray<>
* GenericListArray<>
* GenericStringArray<>
This also does bounds checking to the value() function on each of the above arrays (as well as PrimitiveArray<> ).
The new PrimitiveArray bounds checks changes have a negative performance impact on various benchmarks that still use the .Value(...) function on PrimitiveArray. But that should be resolvable by using the PrimitiveArray.values() instead (whether within this PR or a future PR).
> [Rust] Use slices for simple array data buffer access
> -----------------------------------------------------
>
> Key: ARROW-11270
> URL: https://issues.apache.org/jira/browse/ARROW-11270
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Rust
> Reporter: Tyrel Rink
> Assignee: Tyrel Rink
> Priority: Major
>
> Using an approach similar to ARROW-10989, migrate typed array API's to use slices where they can.
> This impacts the API of:
> * GenericBinaryArray<>
> * GenericListArray<>
> * GenericStringArray<>
> This also enables bounds checking in every value() function on each of the above arrays (as well as PrimitiveArray<> ).
> The new PrimitiveArray.value() bounds check has a negative performance impact on various benchmarks that still use the .Value(...) function on PrimitiveArray. But that should be resolvable by using the PrimitiveArray.values() instead (whether within this PR or a future PR).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)