[GitHub] [arrow-adbc] WillAyd commented on a diff in pull request #790: test(python): set up pyright

["WillAyd (via GitHub)" <gi...@apache.org>]

WillAyd commented on code in PR #790:
URL: https://github.com/apache/arrow-adbc/pull/790#discussion_r1229938537


##########
python/adbc_driver_manager/adbc_driver_manager/_lib.pyi:
##########
@@ -0,0 +1,130 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from typing import Any, ClassVar, Dict, List, Optional, Tuple, Union
+
+from typing import overload
+import enum
+import typing
+
+INGEST_OPTION_MODE: str
+INGEST_OPTION_MODE_APPEND: str
+INGEST_OPTION_MODE_CREATE: str
+INGEST_OPTION_TARGET_TABLE: str
+
+class AdbcConnection(_AdbcHandle):
+    def __init__(self, *args, **kwargs) -> None: ...
+    def close(self, *args, **kwargs) -> Any: ...
+    def commit(self, *args, **kwargs) -> Any: ...
+    def get_info(self, *args, **kwargs) -> Any: ...
+    def get_objects(self, *args, **kwargs) -> Any: ...
+    def get_table_schema(self, *args, **kwargs) -> Any: ...
+    def get_table_types(self, *args, **kwargs) -> Any: ...
+    def read_partition(self, *args, **kwargs) -> Any: ...
+    def rollback(self, *args, **kwargs) -> Any: ...
+    def set_autocommit(self, *args, **kwargs) -> Any: ...
+    def set_options(self, *args, **kwargs) -> Any: ...
+
+class AdbcDatabase(_AdbcHandle):
+    def __init__(self, **kwargs: Dict[str, str]) -> None: ...
+    def close(self, *args, **kwargs) -> Any: ...
+    def set_options(self, *args, **kwargs) -> Any: ...
+
+class AdbcInfoCode(enum.IntEnum):
+    DRIVER_ARROW_VERSION: ClassVar[AdbcInfoCode] = ...

Review Comment:
   Were the `ClassVar` annotations here auto-generated? I probably have out of date knowledge on annotations but haven't seen that pattern before



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org