You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2017/04/11 18:30:26 UTC

[Bug 7404] New: MS::PerMsgStatus::get_content_preview

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7404

            Bug ID: 7404
           Summary: MS::PerMsgStatus::get_content_preview
           Product: Spamassassin
           Version: 3.4.1
          Hardware: PC
                OS: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Libraries
          Assignee: dev@spamassassin.apache.org
          Reporter: Mark.Martinec@ijs.si
  Target Milestone: Undefined

t/autolearn.t ..................... Unescaped left brace in regex is deprecated
here (and will be fatal in Perl 5.30), passed through in regex; marked by <--
HERE in m/^(.{ <-- HERE ,200}).*$/ at
../blib/lib/Mail/SpamAssassin/PerMsgStatus.pm line 923.

perl 5.25.11

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7404] Bad regexp (and logic) in MS::PerMsgStatus::get_content_preview

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7404

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Mark Martinec <Ma...@ijs.si> ---
closing, resolved

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: [Bug 7404] New: MS::PerMsgStatus::get_content_preview

Posted by John Hardin <jh...@impsec.org>.
On Tue, 11 Apr 2017, bugzilla-daemon@issues.apache.org wrote:

> https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7404
>
>            Bug ID: 7404
>           Summary: MS::PerMsgStatus::get_content_preview
>
> t/autolearn.t ..................... Unescaped left brace in regex is deprecated
> here (and will be fatal in Perl 5.30), passed through in regex; marked by <--
> HERE in m/^(.{ <-- HERE ,200}).*$/ at
> ../blib/lib/Mail/SpamAssassin/PerMsgStatus.pm line 923.
>
> perl 5.25.11

I remember discussing that (and embarrassing myself because that syntax IS 
valid in sed but not perl) a while back. That bug may be a dupe...

-- 
  John Hardin KA7OHZ                    http://www.impsec.org/~jhardin/
  jhardin@impsec.org    FALaholic #11174     pgpk -a jhardin@impsec.org
  key: 0xB8732E79 -- 2D8C 34F4 6411 F507 136C  AF76 D822 E6E6 B873 2E79
-----------------------------------------------------------------------
   If you are "fighting for social justice," then you are defining
   yourself as someone who considers regular old everyday
   *equal* justice to be something you don't want.       -- GOF at TSM
-----------------------------------------------------------------------
  2 days until Thomas Jefferson's 274th Birthday

[Bug 7404] Bad regexp (and logic) in MS::PerMsgStatus::get_content_preview

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7404

--- Comment #2 from Mark Martinec <Ma...@ijs.si> ---
Created attachment 5441
  --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5441&action=edit
Fixes inappropriate regexp (and surrounding logic)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7404] Bad regexp (and logic) in MS::PerMsgStatus::get_content_preview

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7404

--- Comment #3 from Mark Martinec <Ma...@ijs.si> ---
3.4:
  Sending PerMsgStatus.pm
Committed revision 1791013.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7404] Bad regexp (and logic) in MS::PerMsgStatus::get_content_preview

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7404

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|MS::PerMsgStatus::get_conte |Bad regexp (and logic) in
                   |nt_preview                  |MS::PerMsgStatus::get_conte
                   |                            |nt_preview
   Target Milestone|Undefined                   |3.4.2

--- Comment #1 from Mark Martinec <Ma...@ijs.si> ---
(sorry for hitting a submit prematurely on an unfinished PR)

Testing with 5.25.11 (soon to be be released as 5.26) fills the log
with warnings on a suspicious regexp, as shown above - an x{,n}
is not interpreted as x{0,n}, and even if it were, the logic is wrong
in that code.

fixing in trunk:
  Sending lib/Mail/SpamAssassin/PerMsgStatus.pm
Committed revision 1791010.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7404] Bad regexp (and logic) in MS::PerMsgStatus::get_content_preview

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7404

Bill Cole <sa...@billmail.scconsult.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |waltman@pobox.com

--- Comment #8 from Bill Cole <sa...@billmail.scconsult.com> ---
*** Bug 7480 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7404] Bad regexp (and logic) in MS::PerMsgStatus::get_content_preview

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7404

Bill Cole <sa...@billmail.scconsult.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |trond.endrestol@ximalas.inf
                   |                            |o

--- Comment #6 from Bill Cole <sa...@billmail.scconsult.com> ---
*** Bug 7444 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7404] Bad regexp (and logic) in MS::PerMsgStatus::get_content_preview

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7404

Bill Cole <sa...@billmail.scconsult.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexchorny@gmail.com

--- Comment #5 from Bill Cole <sa...@billmail.scconsult.com> ---
*** Bug 7369 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7404] Bad regexp (and logic) in MS::PerMsgStatus::get_content_preview

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7404

Kevin A. McGrail <km...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |christophe.troestler@umons.
                   |                            |ac.be

--- Comment #7 from Kevin A. McGrail <km...@apache.org> ---
*** Bug 7448 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.