You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2013/05/06 17:39:19 UTC

[Bug 122241] New: A set MapMode does not survive a Push/Pop call pair when mapping is temporarily disabled

https://issues.apache.org/ooo/show_bug.cgi?id=122241

            Bug ID: 122241
        Issue Type: DEFECT
           Summary: A set MapMode does not survive a Push/Pop call pair
                    when mapping is temporarily disabled
    Classification: Code
           Product: General
           Version: AOO400-dev
          Hardware: All
                OS: All
            Status: CONFIRMED
          Severity: normal
          Priority: P3
         Component: code
          Assignee: issues@openoffice.apache.org
          Reporter: Armin.Le.Grand@me.com
                CC: issues@openoffice.apache.org

ALG: Push/Pop at OutputDevice is used to secure e.g. MapMode over content
handling. When using PUSH_MAPMODE as flag, the MapMode is to be pushed and
Poped. When during this Push/Pop mapping is temporarily disabled using
EnableMapMode(false), the MapMode will not survive this Push/Pop pair. Exmaple
code:

const bool bWasOn(dev.IsMapModeEnabled());
dev.EnableMapMode(false);
...
dev.Push(  PUSH_MAPMODE or nothing );
...
dev.Pop();
...
dev.EnableMapMode(bWasOn);

MapMode will be default (MAP_PIXEL) and empty, mbMap will be false after Pop,
true after last line above, but useless.
This is an even more dangerous trap when Push/Pop is inside a called
sub-routine and it is not obvious why after temporarily disabling the mapping
the MapMode is lost.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 122241] A set MapMode does not survive a Push/Pop call pair when mapping is temporarily disabled

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122241

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ACCEPTED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Armin Le Grand <Ar...@me.com> ---
ALG: Done, comitted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 122241] A set MapMode does not survive a Push/Pop call pair when mapping is temporarily disabled

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122241

--- Comment #2 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1479828 into trunk:
i122241 Made Push/Pop with PUSH_MAPMODE safe for mbMap flag and MapMode
prese...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 122241] A set MapMode does not survive a Push/Pop call pair when mapping is temporarily disabled

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122241

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |AOO 4.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 122241] A set MapMode does not survive a Push/Pop call pair when mapping is temporarily disabled

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122241

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |ACCEPTED
           Assignee|issues@openoffice.apache.or |Armin.Le.Grand@me.com
                   |g                           |

--- Comment #1 from Armin Le Grand <Ar...@me.com> ---
ALG: Grepping. Solution is to remember MapMode independent from mbMap state in
Push() and to also rmrmber mbMap itself.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.