You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2022/06/02 14:13:25 UTC

[Impala-ASF-CR] IMPALA-11335: allocate WriteId before taking locks during INSERT to ACID tables

Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18583


Change subject: IMPALA-11335: allocate WriteId before taking locks during INSERT to ACID tables
......................................................................

IMPALA-11335: allocate WriteId before taking locks during INSERT to ACID tables

It turned out that in case of INSERT HMS uses the writeId during lock
creation to save it and use it to cleanup aborted / timeouted
transactions. See the Jira for more details.

Testing:
- It is tricky to test this, so no new test was added. Hive should
  check whether there is already a new writeId for a table during
  lock creation and return an error if not - this would ensure
  that the correct behavior of Impala is tested.

Change-Id: Ic13b8822662474a0d2d4d1a31f12745159c758f4
---
M fe/src/main/java/org/apache/impala/service/Frontend.java
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/18583/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic13b8822662474a0d2d4d1a31f12745159c758f4
Gerrit-Change-Number: 18583
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>

[Impala-ASF-CR] IMPALA-11335: allocate WriteId before taking locks during INSERT to ACID tables

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.

Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18583 )

Change subject: IMPALA-11335: allocate WriteId before taking locks during INSERT to ACID tables
......................................................................

IMPALA-11335: allocate WriteId before taking locks during INSERT to ACID tables

It turned out that in case of INSERT HMS uses the writeId during lock
creation to save it and use it to cleanup aborted / timeouted
transactions. See the Jira for more details.

Testing:
- It is tricky to test this, so no new test was added. Hive should
  check whether there is already a new writeId for a table during
  lock creation and return an error if not - this would ensure
  that the correct behavior of Impala is tested.

Change-Id: Ic13b8822662474a0d2d4d1a31f12745159c758f4
Reviewed-on: http://gerrit.cloudera.org:8080/18583
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Zoltan Borok-Nagy <bo...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/service/Frontend.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Zoltan Borok-Nagy: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic13b8822662474a0d2d4d1a31f12745159c758f4
Gerrit-Change-Number: 18583
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11335: allocate WriteId before taking locks during INSERT to ACID tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18583 )

Change subject: IMPALA-11335: allocate WriteId before taking locks during INSERT to ACID tables
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10684/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic13b8822662474a0d2d4d1a31f12745159c758f4
Gerrit-Change-Number: 18583
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Jun 2022 14:33:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11335: allocate WriteId before taking locks during INSERT to ACID tables

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.

Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18583 )

Change subject: IMPALA-11335: allocate WriteId before taking locks during INSERT to ACID tables
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic13b8822662474a0d2d4d1a31f12745159c758f4
Gerrit-Change-Number: 18583
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Jun 2022 16:13:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11335: allocate WriteId before taking locks during INSERT to ACID tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18583 )

Change subject: IMPALA-11335: allocate WriteId before taking locks during INSERT to ACID tables
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8180/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic13b8822662474a0d2d4d1a31f12745159c758f4
Gerrit-Change-Number: 18583
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Jun 2022 14:14:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11335: allocate WriteId before taking locks during INSERT to ACID tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18583 )

Change subject: IMPALA-11335: allocate WriteId before taking locks during INSERT to ACID tables
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic13b8822662474a0d2d4d1a31f12745159c758f4
Gerrit-Change-Number: 18583
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Jun 2022 18:42:01 +0000
Gerrit-HasComments: No