You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by daan Hoogland <da...@gmail.com> on 2013/06/20 23:49:05 UTC

Review Request: jsonHelper.py cleanup

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12017/
-----------------------------------------------------------

Review request for cloudstack and Sebastien Goasguen.


Description
-------

.jsonHelper cleanup
I took some artistic freedom regarding long strings in json structs. It would have defeated the purpose of formatting (readability) if I hadn't I feel. As a result the file has still one message on a pep8 run.


This addresses bug CLOUDSTACK-3096.


Diffs
-----

  tools/marvin/marvin/jsonHelper.py 79a6369 

Diff: https://reviews.apache.org/r/12017/diff/


Testing
-------


Thanks,

daan Hoogland


Re: Review Request: jsonHelper.py cleanup

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12017/#review22240
-----------------------------------------------------------

Ship it!


c03ba0c8e6904b86d46d86055f05a0c047af190d

- Prasanna Santhanam


On June 20, 2013, 9:49 p.m., daan Hoogland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12017/
> -----------------------------------------------------------
> 
> (Updated June 20, 2013, 9:49 p.m.)
> 
> 
> Review request for cloudstack and Sebastien Goasguen.
> 
> 
> Description
> -------
> 
> .jsonHelper cleanup
> I took some artistic freedom regarding long strings in json structs. It would have defeated the purpose of formatting (readability) if I hadn't I feel. As a result the file has still one message on a pep8 run.
> 
> 
> This addresses bug CLOUDSTACK-3096.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/jsonHelper.py 79a6369 
> 
> Diff: https://reviews.apache.org/r/12017/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> daan Hoogland
> 
>