You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/21 02:29:37 UTC
[GitHub] [incubator-superset] john-bodley opened a new pull request #9339:
[config] Fixing GET_FEATURE_FLAGS_FUNC example
john-bodley opened a new pull request #9339: [config] Fixing GET_FEATURE_FLAGS_FUNC example
URL: https://github.com/apache/incubator-superset/pull/9339
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
@etr2460 discovered that the `GET_FEATURE_FLAGS_FUNC` example fails when using the `superset` CLI as no Flask user exists. This PR modifies the example to first check if a user is defined and active.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
Used the same pattern in development.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
to: @etr2460
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request
#9339: [config] Fixing GET_FEATURE_FLAGS_FUNC example
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #9339: [config] Fixing GET_FEATURE_FLAGS_FUNC example
URL: https://github.com/apache/incubator-superset/pull/9339#discussion_r396006810
##########
File path: superset/config.py
##########
@@ -302,7 +302,8 @@ def _try_json_readsha(filepath, length): # pylint: disable=unused-argument
#
# from flask import g, request
# def GET_FEATURE_FLAGS_FUNC(feature_flags_dict):
Review comment:
can we add typing to this example too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley merged pull request #9339:
[config] Fixing GET_FEATURE_FLAGS_FUNC example
Posted by GitBox <gi...@apache.org>.
john-bodley merged pull request #9339: [config] Fixing GET_FEATURE_FLAGS_FUNC example
URL: https://github.com/apache/incubator-superset/pull/9339
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9339: [config]
Fixing GET_FEATURE_FLAGS_FUNC example
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9339: [config] Fixing GET_FEATURE_FLAGS_FUNC example
URL: https://github.com/apache/incubator-superset/pull/9339#issuecomment-601981946
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9339?src=pr&el=h1) Report
> Merging [#9339](https://codecov.io/gh/apache/incubator-superset/pull/9339?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/232925b7bf0e2ffbe23029a77a97223663830968&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9339?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9339 +/- ##
=======================================
Coverage 58.96% 58.96%
=======================================
Files 374 374
Lines 12137 12137
Branches 2992 2992
=======================================
Hits 7156 7156
Misses 4802 4802
Partials 179 179
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9339?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9339?src=pr&el=footer). Last update [232925b...05480ed](https://codecov.io/gh/apache/incubator-superset/pull/9339?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9339:
[config] Fixing GET_FEATURE_FLAGS_FUNC example
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9339: [config] Fixing GET_FEATURE_FLAGS_FUNC example
URL: https://github.com/apache/incubator-superset/pull/9339#issuecomment-601981946
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9339?src=pr&el=h1) Report
> Merging [#9339](https://codecov.io/gh/apache/incubator-superset/pull/9339?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/232925b7bf0e2ffbe23029a77a97223663830968&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9339?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9339 +/- ##
=======================================
Coverage 58.96% 58.96%
=======================================
Files 374 374
Lines 12137 12137
Branches 2992 2992
=======================================
Hits 7156 7156
Misses 4802 4802
Partials 179 179
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9339?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9339?src=pr&el=footer). Last update [232925b...b5ffb58](https://codecov.io/gh/apache/incubator-superset/pull/9339?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9339:
[config] Fixing GET_FEATURE_FLAGS_FUNC example
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9339: [config] Fixing GET_FEATURE_FLAGS_FUNC example
URL: https://github.com/apache/incubator-superset/pull/9339#issuecomment-601981946
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9339?src=pr&el=h1) Report
> Merging [#9339](https://codecov.io/gh/apache/incubator-superset/pull/9339?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/232925b7bf0e2ffbe23029a77a97223663830968&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9339?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9339 +/- ##
=======================================
Coverage 58.96% 58.96%
=======================================
Files 374 374
Lines 12137 12137
Branches 2992 2992
=======================================
Hits 7156 7156
Misses 4802 4802
Partials 179 179
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9339?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9339?src=pr&el=footer). Last update [232925b...b5ffb58](https://codecov.io/gh/apache/incubator-superset/pull/9339?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org