You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Michael Dürig (JIRA)" <ji...@apache.org> on 2013/02/01 22:54:12 UTC

[jira] [Reopened] (OAK-568) Duplicated code in TreeLocation implementations

     [ https://issues.apache.org/jira/browse/OAK-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Dürig reopened OAK-568:
-------------------------------


I think we should revisit this issue: while the abstract base classes introduce quite some complexity (e.g. type parametrisation), they only remove trivial code duplications. The bulk of the code is still duplicated in {{TreeImpl}} and {{ReadOnlyTree}} (e.g. {{getChild()}}).

The problem with the duplicate code in {{getChild()}} is that currently we do not properly abstract over the different {{Tree}} implementations. In order to do so we would need a way to access some of the internal methods in an uniform way. 
                
> Duplicated code in TreeLocation implementations
> -----------------------------------------------
>
>                 Key: OAK-568
>                 URL: https://issues.apache.org/jira/browse/OAK-568
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: angela
>             Fix For: 0.6
>
>         Attachments: OAK-568.patch
>
>
> see proposed patch to get rid of the duplicated code in the 4 implementations
> of TreeLocation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira