You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by gnethercutt <gi...@git.apache.org> on 2016/09/29 05:02:37 UTC
[GitHub] zookeeper pull request #83: enable TCP keepalive for the leadership election...
GitHub user gnethercutt opened a pull request:
https://github.com/apache/zookeeper/pull/83
enable TCP keepalive for the leadership election/quorum socket
Use TCP keep-alives for election/quorum peer connections.
This is the shortest edit distance to address [ZOOKEEPER-1748](https://issues.apache.org/jira/browse/ZOOKEEPER-1748), and is required to avoid silent packet delivery failures for a long-lived connection in AWS (amongst other environments).
See also:
- [VPC security group connection tracking](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-network-security.html#security-group-connection-tracking)
- [Using TCP keepalives](http://tldp.org/HOWTO/TCP-Keepalive-HOWTO/usingkeepalive.html)
- [Zookeeper internals](https://zookeeper.apache.org/doc/r3.4.8/zookeeperInternals.html)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gnethercutt/zookeeper election_tcp_keepalive
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/83.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #83
----
commit bcab41003d91dc121e368337317710c2434bece8
Author: Glenn Nethercutt <gl...@inin.com>
Date: 2016-09-28T18:22:41Z
enable TCP keepalive for the leadership election/quorum socket
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #83: enable TCP keepalive for the leadership election/quorum...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/83
Thanks for the patch and detailed tech reports @gnethercutt.
As @rgs1 commented on ZOOKEEPER-1748 JIRA we should have a feature switch that controls on / off of the keep alive option. It should be pretty trivial to add (one line code in QuorumPeerConfig and some lines on the doc update.). Will you be able to add this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #83: enable TCP keepalive for the leadership election/quorum...
Posted by bensherman <gi...@git.apache.org>.
Github user bensherman commented on the issue:
https://github.com/apache/zookeeper/pull/83
@gnethercutt I'd like to get this into 3.4.x and 3.5.x, do you mind if I take it over?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---