You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by "Brijesh619 (via GitHub)" <gi...@apache.org> on 2026/06/09 11:55:31 UTC
[PR] ATLAS-5306: Atlas React UI: SearchResult Table: Classification toolti… [atlas]
Brijesh619 opened a new pull request, #665:
URL: https://github.com/apache/atlas/pull/665
UI & Layout Improvements (DialogShowMoreLess)
Chip Sizing & Truncation: Reduced the maximum chip width from 200px to 100px. Added proper text truncation (overflow: hidden, textOverflow: ellipsis, whiteSpace: nowrap) to ensure long text in chips is handled gracefully without overflowing boundaries.
Tag List Layout: Refactored the tag-list container to dynamically switch to a structured CSS Grid layout when isShowMoreLess is true, ensuring proper alignment of elements instead of relying purely on flex-wrapping.
Icon Alignment: Prevented the More Options and Add icons from shrinking when the container lacks space by adding flexShrink: 0 and optimizing padding.
Label Resolution: Updated the getLabel logic to appropriately reuse the checkSuperTypes utility for both "Classification" and "Propagated Classification" column types.
Toast Messaging: Improved the string formatting of the success toast message when a term/association is successfully removed.
Search Results Table (SearchResult)
Column Sizing: Explicitly defined a column size of 100 for both the Owner and Type columns in the Search Results table.
Table Wrapper: Wrapped the <TableLayout /> component in a new search-result-table-wrapper container to provide better structural styling control.
Code Cleanup: Refactored and cleaned up the class name interpolation for the entity Link component.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5306: Atlas React UI: SearchResult Table: Classification toolti… [atlas]
Posted by "kevalbhatt (via GitHub)" <gi...@apache.org>.
kevalbhatt commented on code in PR #665:
URL: https://github.com/apache/atlas/pull/665#discussion_r3383415702
##########
dashboard/src/components/DialogShowMoreLess.tsx:
##########
@@ -37,7 +37,7 @@ import { fetchGlossaryDetails } from "@redux/slice/glossaryDetailsSlice";
import { fetchDetailPageData } from "@redux/slice/detailPageSlice";
import { fetchGlossaryData } from "@redux/slice/glossarySlice";
-const CHIP_MAX_WIDTH = "200px";
+const CHIP_MAX_WIDTH = "100px";
Review Comment:
nit; Better to use rem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5306: Atlas React UI: SearchResult Table: Classification toolti… [atlas]
Posted by "kevalbhatt (via GitHub)" <gi...@apache.org>.
kevalbhatt commented on code in PR #665:
URL: https://github.com/apache/atlas/pull/665#discussion_r3383427821
##########
dashboard/src/components/DialogShowMoreLess.tsx:
##########
@@ -352,7 +354,16 @@ const DialogShowMoreLess = ({
{value?.[columnVal]?.length > 0 ? (
<div
className="tag-list"
- style={{ flexWrap: isShowMoreLess ? "nowrap" : "wrap" }}
+ style={
+ isShowMoreLess
Review Comment:
why not to use https://mui.com/system/flexbox/?
inline style is not good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5306: Atlas React UI: SearchResult Table: Classification toolti… [atlas]
Posted by "kevalbhatt (via GitHub)" <gi...@apache.org>.
kevalbhatt commented on code in PR #665:
URL: https://github.com/apache/atlas/pull/665#discussion_r3383410305
##########
dashboard/src/components/DialogShowMoreLess.tsx:
##########
@@ -352,7 +354,16 @@ const DialogShowMoreLess = ({
{value?.[columnVal]?.length > 0 ? (
<div
className="tag-list"
- style={{ flexWrap: isShowMoreLess ? "nowrap" : "wrap" }}
+ style={
Review Comment:
why not to use https://mui.com/system/flexbox/?
inline style is not good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5306: Atlas React UI: SearchResult Table: Classification toolti… [atlas]
Posted by "Brijesh619 (via GitHub)" <gi...@apache.org>.
Brijesh619 commented on PR #665:
URL: https://github.com/apache/atlas/pull/665#issuecomment-4659485373
<img width="1357" height="693" alt="Screenshot from 2026-06-09 17-29-05" src="https://github.com/user-attachments/assets/a25119ef-bd63-45b6-b214-f02339df7dc9" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5306: Atlas React UI: SearchResult Table: Classification toolti… [atlas]
Posted by "Brijesh619 (via GitHub)" <gi...@apache.org>.
Brijesh619 commented on PR #665:
URL: https://github.com/apache/atlas/pull/665#issuecomment-4669354750
Hi @kevalbhatt ,
i had handled your review comments on this PR and updated the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5306: Atlas React UI: SearchResult Table: Classification toolti… [atlas]
Posted by "kevalbhatt (via GitHub)" <gi...@apache.org>.
kevalbhatt commented on code in PR #665:
URL: https://github.com/apache/atlas/pull/665#discussion_r3383396722
##########
dashboard/src/components/DialogShowMoreLess.tsx:
##########
@@ -268,7 +267,10 @@ const DialogShowMoreLess = ({
};
const getLabel = (label: string, optionalLabel?: string) => {
- if (columnVal == "Classifications" || columnVal == "self") {
+ if (colName == "Classification") {
Review Comment:
nit; better to use const or enum insted of string "Classification"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5306: Atlas React UI: SearchResult Table: Classification toolti… [atlas]
Posted by "Brijesh619 (via GitHub)" <gi...@apache.org>.
Brijesh619 commented on PR #665:
URL: https://github.com/apache/atlas/pull/665#issuecomment-4659477616
![Uploading Screenshot from 2026-06-09 17-27-50.png…]()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5306: Atlas React UI: SearchResult Table: Classification toolti… [atlas]
Posted by "kevalbhatt (via GitHub)" <gi...@apache.org>.
kevalbhatt commented on code in PR #665:
URL: https://github.com/apache/atlas/pull/665#discussion_r3383410305
##########
dashboard/src/components/DialogShowMoreLess.tsx:
##########
@@ -352,7 +354,16 @@ const DialogShowMoreLess = ({
{value?.[columnVal]?.length > 0 ? (
<div
className="tag-list"
- style={{ flexWrap: isShowMoreLess ? "nowrap" : "wrap" }}
+ style={
Review Comment:
why not to use https://mui.com/system/flexbox/?
inline style is not good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5306: Atlas React UI: SearchResult Table: Classification toolti… [atlas]
Posted by "Brijesh619 (via GitHub)" <gi...@apache.org>.
Brijesh619 commented on PR #665:
URL: https://github.com/apache/atlas/pull/665#issuecomment-4659466173
<img width="1366" height="768" alt="Screenshot from 2026-06-09 15-50-07" src="https://github.com/user-attachments/assets/ec08458d-2595-4bbb-8913-c1aa1a7c3b12" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5306: Atlas React UI: SearchResult Table: Classification toolti… [atlas]
Posted by "pawarprasad123 (via GitHub)" <gi...@apache.org>.
pawarprasad123 merged PR #665:
URL: https://github.com/apache/atlas/pull/665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5306: Atlas React UI: SearchResult Table: Classification toolti… [atlas]
Posted by "Brijesh619 (via GitHub)" <gi...@apache.org>.
Brijesh619 commented on PR #665:
URL: https://github.com/apache/atlas/pull/665#issuecomment-4679751390
<img width="1357" height="693" alt="Screenshot from 2026-06-11 16-18-14" src="https://github.com/user-attachments/assets/fa8e3d2b-7783-44af-a5a6-88a677865903" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org