You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by rmetzger <gi...@git.apache.org> on 2017/02/17 12:26:58 UTC
[GitHub] flink pull request #3344: FLINK-5731 Spilt up tests into three disjoint grou...
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/3344
FLINK-5731 Spilt up tests into three disjoint groups
We were running into build timeouts again recently on travis.
That's why I've split the tests into three groups (instead of two).
This means we'll have 12 test jobs (5 run concurrently)
I'm not sure if we want to merge this or not. It gives us only 10 more minutes on the slowest builds, so we'll run into the issue again at some point.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink flink5731
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3344.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3344
----
commit b242b3838695805e191fad55684b05c779084897
Author: Robert Metzger <rm...@apache.org>
Date: 2017-02-13T20:43:25Z
FLINK-5731 Spilt up tests into three disjoint groups
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3344: FLINK-5731 Spilt up tests into three disjoint groups
Posted by addisonj <gi...@git.apache.org>.
Github user addisonj commented on the issue:
https://github.com/apache/flink/pull/3344
Even with this in place, I am still regularly seeing timeouts on quite a few PRs. In addition to the travis queue being backed up, its taking 12+ hours to get feedback which is mostly just build timeouts :|
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3344: FLINK-5731 Spilt up tests into three disjoint groups
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3344
Since this is so easy to undo, I'll merge it for now. Lets see if people start complaining
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3344: FLINK-5731 Spilt up tests into three disjoint groups
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3344
Ten minutes allows for a significant number of new tests. Alternatively, we did look at parallelizing the tests but there were some dependency issues and the PR expired in review.
This does need fixed, but as you note the longer we put this off the deeper we dig ourselves in a hole. Are we looking to split the libraries out of the main repo?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3344: FLINK-5731 Spilt up tests into three disjoint groups
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3344
I think that 10 minutes are actually quite an improvement. Currently, the PR builds usually time out and we only see red crosses next to the PR (including this one ;)). I would certainly try this setup.
I also see that this is not a long term solution. @greghogan I don't know what the plans are about splitting the repository. The discussion stalled, because there was no solution that made all contributors/committers happy I think. I think we really need someone who can drive the discussion and has time available to try different setups, etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3344: FLINK-5731 Spilt up tests into three disjoint groups
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3344
I agree that we have this issue again.
If you want faster feedback on your pull requests, I recommend setting up travis for your flink fork. Then, every time you push to your repo, you'll immediately start your own build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3344: FLINK-5731 Spilt up tests into three disjoint groups
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3344
Thank you for your feedback. The feedback seems to be clearer than expected.
If there are no objections within the next days, I'll merge the change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3344: FLINK-5731 Spilt up tests into three disjoint grou...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3344
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---