You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by grimreaper <gi...@git.apache.org> on 2018/07/24 03:22:54 UTC

[GitHub] commons-collections pull request #48: global: make use of FunctionalInterfac...

GitHub user grimreaper opened a pull request:

    https://github.com/apache/commons-collections/pull/48

    global: make use of FunctionalInterface

    Now that we're using Java 8, it seems reasonable to annotate.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/grimreaper/commons-collections eax/finter/now

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-collections/pull/48.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #48
    
----
commit e980ed410d3f61889b52d9b8d7b873e279c8a54c
Author: Eitan Adler <li...@...>
Date:   2018-07-24T03:20:31Z

    global: make use of FunctionalInterface
    
    Now that we're using Java 8, it seems reasonable to annotate classes.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

[GitHub] commons-collections issue #48: global: make use of FunctionalInterface

Posted by soc <gi...@git.apache.org>.
Github user soc commented on the issue:

    https://github.com/apache/commons-collections/pull/48
  
    @grimreaper Would it make sense in general to also annotate interfaces that just duplicate the ones in `java.util.function` with `@Deprecated`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

[GitHub] commons-collections issue #48: global: make use of FunctionalInterface

Posted by grimreaper <gi...@git.apache.org>.
Github user grimreaper commented on the issue:

    https://github.com/apache/commons-collections/pull/48
  
    IMHO yes, though that should be done separately. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org