You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/19 09:10:21 UTC

[GitHub] [flink] dianfu commented on a diff in pull request #19765: [FLINK-27676][python] Fix on_timer output behind triggering watermark

dianfu commented on code in PR #19765:
URL: https://github.com/apache/flink/pull/19765#discussion_r876810959


##########
flink-python/src/main/java/org/apache/flink/streaming/api/operators/python/timer/TimerRegistration.java:
##########
@@ -105,6 +111,17 @@ private void setTimer(TimerOperandType operandType, long timestamp, Row key, Obj
         }
     }
 
+    /**
+     * Returns if there's any event-time timer in the queue, that should be triggered because
+     * watermark advance.
+     */
+    public boolean isTimerQueueClean(long watermark) throws Exception {

Review Comment:
   ```suggestion
       public boolean hasEventTimeTimerBeforeTimestamp(long watermark) throws Exception {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org