You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Mark Hindess (JIRA)" <ji...@apache.org> on 2006/04/24 15:31:05 UTC
[jira] Created: (HARMONY-404) Wild card exclusions are excluding
working tests
Wild card exclusions are excluding working tests
------------------------------------------------
Key: HARMONY-404
URL: http://issues.apache.org/jira/browse/HARMONY-404
Project: Harmony
Type: Improvement
Components: Classlib
Reporter: Mark Hindess
Priority: Trivial
The use of "**/TargetTest.java" exclusions means we are excluding tests that work just because they have the same file name. For example, modules/archive/make/common/build.xml excludes both:
modules/archive/src/test/java/org/apache/harmony/tests/java/util/zip/InflaterTest.java
modules/archive/src/test/java/tests/api/java/util/zip/InflaterTest.java
even though the latter is the only one that fails.
I will attach a patch to enable the incorrectly excluded tests.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-404) Wild card exclusions are excluding
working tests
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-404?page=comments#action_12376704 ]
Mark Hindess commented on HARMONY-404:
--------------------------------------
Ah. Actually I was wrong. Since you didn't use the updated patch the full paths for the text module excludes are wrong... They need to take account of the renames.
> Wild card exclusions are excluding working tests
> ------------------------------------------------
>
> Key: HARMONY-404
> URL: http://issues.apache.org/jira/browse/HARMONY-404
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Mark Hindess
> Assignee: Mikhail Loenko
> Priority: Trivial
> Attachments: 20060427.update.diff, exclude.specific.test.files.diff
>
> The use of "**/TargetTest.java" exclusions means we are excluding tests that work just because they have the same file name. For example, modules/archive/make/common/build.xml excludes both:
> modules/archive/src/test/java/org/apache/harmony/tests/java/util/zip/InflaterTest.java
> modules/archive/src/test/java/tests/api/java/util/zip/InflaterTest.java
> even though the latter is the only one that fails.
> I will attach a patch to enable the incorrectly excluded tests.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-404) Wild card exclusions are excluding
working tests
Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-404?page=all ]
Mikhail Loenko resolved HARMONY-404:
------------------------------------
Resolution: Fixed
fixed in revision 397499
Mark, please verify it fully resolves your problem
> Wild card exclusions are excluding working tests
> ------------------------------------------------
>
> Key: HARMONY-404
> URL: http://issues.apache.org/jira/browse/HARMONY-404
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Mark Hindess
> Assignee: Mikhail Loenko
> Priority: Trivial
> Attachments: 20060427.update.diff, exclude.specific.test.files.diff
>
> The use of "**/TargetTest.java" exclusions means we are excluding tests that work just because they have the same file name. For example, modules/archive/make/common/build.xml excludes both:
> modules/archive/src/test/java/org/apache/harmony/tests/java/util/zip/InflaterTest.java
> modules/archive/src/test/java/tests/api/java/util/zip/InflaterTest.java
> even though the latter is the only one that fails.
> I will attach a patch to enable the incorrectly excluded tests.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-404) Wild card exclusions are excluding
working tests
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-404?page=comments#action_12376878 ]
Mark Hindess commented on HARMONY-404:
--------------------------------------
Really looks good this time. Thanks Mikhail.
> Wild card exclusions are excluding working tests
> ------------------------------------------------
>
> Key: HARMONY-404
> URL: http://issues.apache.org/jira/browse/HARMONY-404
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Mark Hindess
> Assignee: Mikhail Loenko
> Priority: Trivial
> Attachments: 20060427.update.diff, exclude.specific.test.files.diff
>
> The use of "**/TargetTest.java" exclusions means we are excluding tests that work just because they have the same file name. For example, modules/archive/make/common/build.xml excludes both:
> modules/archive/src/test/java/org/apache/harmony/tests/java/util/zip/InflaterTest.java
> modules/archive/src/test/java/tests/api/java/util/zip/InflaterTest.java
> even though the latter is the only one that fails.
> I will attach a patch to enable the incorrectly excluded tests.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-404) Wild card exclusions are excluding
working tests
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-404?page=comments#action_12376700 ]
Mark Hindess commented on HARMONY-404:
--------------------------------------
Looks good. Thanks Mikhail.
> Wild card exclusions are excluding working tests
> ------------------------------------------------
>
> Key: HARMONY-404
> URL: http://issues.apache.org/jira/browse/HARMONY-404
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Mark Hindess
> Assignee: Mikhail Loenko
> Priority: Trivial
> Attachments: 20060427.update.diff, exclude.specific.test.files.diff
>
> The use of "**/TargetTest.java" exclusions means we are excluding tests that work just because they have the same file name. For example, modules/archive/make/common/build.xml excludes both:
> modules/archive/src/test/java/org/apache/harmony/tests/java/util/zip/InflaterTest.java
> modules/archive/src/test/java/tests/api/java/util/zip/InflaterTest.java
> even though the latter is the only one that fails.
> I will attach a patch to enable the incorrectly excluded tests.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-404) Wild card exclusions are excluding
working tests
Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-404?page=all ]
Mikhail Loenko closed HARMONY-404:
----------------------------------
verified by Mark
> Wild card exclusions are excluding working tests
> ------------------------------------------------
>
> Key: HARMONY-404
> URL: http://issues.apache.org/jira/browse/HARMONY-404
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Mark Hindess
> Assignee: Mikhail Loenko
> Priority: Trivial
> Attachments: 20060427.update.diff, exclude.specific.test.files.diff
>
> The use of "**/TargetTest.java" exclusions means we are excluding tests that work just because they have the same file name. For example, modules/archive/make/common/build.xml excludes both:
> modules/archive/src/test/java/org/apache/harmony/tests/java/util/zip/InflaterTest.java
> modules/archive/src/test/java/tests/api/java/util/zip/InflaterTest.java
> even though the latter is the only one that fails.
> I will attach a patch to enable the incorrectly excluded tests.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-404) Wild card exclusions are excluding
working tests
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-404?page=all ]
Mark Hindess updated HARMONY-404:
---------------------------------
Attachment: exclude.specific.test.files.diff
Fix exclusions.
I also include a trivial fix for a test that was broken by
r390052 "Restructure package name of beans tests to java.beans".
> Wild card exclusions are excluding working tests
> ------------------------------------------------
>
> Key: HARMONY-404
> URL: http://issues.apache.org/jira/browse/HARMONY-404
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Mark Hindess
> Priority: Trivial
> Attachments: exclude.specific.test.files.diff
>
> The use of "**/TargetTest.java" exclusions means we are excluding tests that work just because they have the same file name. For example, modules/archive/make/common/build.xml excludes both:
> modules/archive/src/test/java/org/apache/harmony/tests/java/util/zip/InflaterTest.java
> modules/archive/src/test/java/tests/api/java/util/zip/InflaterTest.java
> even though the latter is the only one that fails.
> I will attach a patch to enable the incorrectly excluded tests.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-404) Wild card exclusions are excluding
working tests
Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-404?page=all ]
Mikhail Loenko reassigned HARMONY-404:
--------------------------------------
Assign To: Mikhail Loenko
> Wild card exclusions are excluding working tests
> ------------------------------------------------
>
> Key: HARMONY-404
> URL: http://issues.apache.org/jira/browse/HARMONY-404
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Mark Hindess
> Assignee: Mikhail Loenko
> Priority: Trivial
> Attachments: exclude.specific.test.files.diff
>
> The use of "**/TargetTest.java" exclusions means we are excluding tests that work just because they have the same file name. For example, modules/archive/make/common/build.xml excludes both:
> modules/archive/src/test/java/org/apache/harmony/tests/java/util/zip/InflaterTest.java
> modules/archive/src/test/java/tests/api/java/util/zip/InflaterTest.java
> even though the latter is the only one that fails.
> I will attach a patch to enable the incorrectly excluded tests.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-404) Wild card exclusions are excluding
working tests
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-404?page=all ]
Mark Hindess updated HARMONY-404:
---------------------------------
Attachment: 20060427.update.diff
Updated patch with George's test renames and other fixes.
> Wild card exclusions are excluding working tests
> ------------------------------------------------
>
> Key: HARMONY-404
> URL: http://issues.apache.org/jira/browse/HARMONY-404
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Mark Hindess
> Assignee: Mikhail Loenko
> Priority: Trivial
> Attachments: 20060427.update.diff, exclude.specific.test.files.diff
>
> The use of "**/TargetTest.java" exclusions means we are excluding tests that work just because they have the same file name. For example, modules/archive/make/common/build.xml excludes both:
> modules/archive/src/test/java/org/apache/harmony/tests/java/util/zip/InflaterTest.java
> modules/archive/src/test/java/tests/api/java/util/zip/InflaterTest.java
> even though the latter is the only one that fails.
> I will attach a patch to enable the incorrectly excluded tests.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira