You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2023/10/20 19:40:14 UTC

[Impala-ASF-CR] IMPALA-12510: Floor PlanFragment.maxParallelism at 1

Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20606


Change subject: IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1
......................................................................

IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1

IMPALA-12444 introduce a bug where PlanFragment.maxParallelism_ is set
to 0 if ScanNode.maxScannerThreads_ is 0. This patch fix it by flooring
ScanNode.maxScannerThreads_ and PlanFragment.maxParallelism_ at 1.

Testing:
- Add select star over empty table testcase to
  PlannerTest.testProcessingCost.

Change-Id: Ibfa50abfdb9cdb994c5c3d7904b377a25f5b8b97
---
M fe/src/main/java/org/apache/impala/planner/PlanFragment.java
M fe/src/main/java/org/apache/impala/planner/ScanNode.java
M testdata/workloads/functional-planner/queries/PlannerTest/tpcds-processing-cost.test
3 files changed, 41 insertions(+), 9 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/20606/1
-- 
To view, visit http://gerrit.cloudera.org:8080/20606
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibfa50abfdb9cdb994c5c3d7904b377a25f5b8b97
Gerrit-Change-Number: 20606
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-12510: Floor PlanFragment.maxParallelism at 1

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20606 )

Change subject: IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1
......................................................................


Patch Set 4:

> Patch Set 4: Verified-1
> 
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9827/

This is hit by IMPALA-12187


-- 
To view, visit http://gerrit.cloudera.org:8080/20606
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfa50abfdb9cdb994c5c3d7904b377a25f5b8b97
Gerrit-Change-Number: 20606
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 23 Oct 2023 21:57:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12510: Floor PlanFragment.maxParallelism at 1

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20606 )

Change subject: IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1
......................................................................

IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1

IMPALA-12444 introduce a bug where PlanFragment.maxParallelism_ can be
set to 0. This can happen at scan fragment if table is empty. Number of
scan ranges will be 0, which then propagate to
ScanNode.maxScannerThreads_ and PlanFragment.maxParallelism_.

This patch fix it by flooring ScanNode.maxScannerThreads_ and
PlanFragment.maxParallelism_ at 1.

Testing:
- Add select star over an empty table testcase to
  PlannerTest.testProcessingCost.

Change-Id: Ibfa50abfdb9cdb994c5c3d7904b377a25f5b8b97
Reviewed-on: http://gerrit.cloudera.org:8080/20606
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Riza Suminto <ri...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/planner/PlanFragment.java
M fe/src/main/java/org/apache/impala/planner/ScanNode.java
M testdata/workloads/functional-planner/queries/PlannerTest/tpcds-processing-cost.test
3 files changed, 46 insertions(+), 11 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved
  Riza Suminto: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/20606
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfa50abfdb9cdb994c5c3d7904b377a25f5b8b97
Gerrit-Change-Number: 20606
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>

[Impala-ASF-CR] IMPALA-12510: Floor PlanFragment.maxParallelism at 1

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20606 )

Change subject: IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20606
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfa50abfdb9cdb994c5c3d7904b377a25f5b8b97
Gerrit-Change-Number: 20606
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 23 Oct 2023 16:51:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12510: Floor PlanFragment.maxParallelism at 1

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20606 )

Change subject: IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9827/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/20606
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfa50abfdb9cdb994c5c3d7904b377a25f5b8b97
Gerrit-Change-Number: 20606
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 23 Oct 2023 16:51:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12510: Floor PlanFragment.maxParallelism at 1

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Yida Wu, Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20606

to look at the new patch set (#3).

Change subject: IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1
......................................................................

IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1

IMPALA-12444 introduce a bug where PlanFragment.maxParallelism_ can be
set to 0. This can happen at scan fragment if table is empty. Number of
scan ranges will be 0, which then propagate to
ScanNode.maxScannerThreads_ and PlanFragment.maxParallelism_.

This patch fix it by flooring ScanNode.maxScannerThreads_ and
PlanFragment.maxParallelism_ at 1.

Testing:
- Add select star over an empty table testcase to
  PlannerTest.testProcessingCost.

Change-Id: Ibfa50abfdb9cdb994c5c3d7904b377a25f5b8b97
---
M fe/src/main/java/org/apache/impala/planner/PlanFragment.java
M fe/src/main/java/org/apache/impala/planner/ScanNode.java
M testdata/workloads/functional-planner/queries/PlannerTest/tpcds-processing-cost.test
3 files changed, 46 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/20606/3
-- 
To view, visit http://gerrit.cloudera.org:8080/20606
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibfa50abfdb9cdb994c5c3d7904b377a25f5b8b97
Gerrit-Change-Number: 20606
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>

[Impala-ASF-CR] IMPALA-12510: Floor PlanFragment.maxParallelism at 1

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20606 )

Change subject: IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1
......................................................................


Patch Set 3: Code-Review+2

(2 comments)

Thanks Yida and Wenzhe! Carry +2

http://gerrit.cloudera.org:8080/#/c/20606/2/fe/src/main/java/org/apache/impala/planner/ScanNode.java
File fe/src/main/java/org/apache/impala/planner/ScanNode.java:

http://gerrit.cloudera.org:8080/#/c/20606/2/fe/src/main/java/org/apache/impala/planner/ScanNode.java@89
PS2, Line 89: 
> nit. seems MIN_NUM_SCAN_THREADS is better
Done


http://gerrit.cloudera.org:8080/#/c/20606/2/testdata/workloads/functional-planner/queries/PlannerTest/tpcds-processing-cost.test
File testdata/workloads/functional-planner/queries/PlannerTest/tpcds-processing-cost.test:

http://gerrit.cloudera.org:8080/#/c/20606/2/testdata/workloads/functional-planner/queries/PlannerTest/tpcds-processing-cost.test@1
PS2, Line 1: # Regression test for IMPALA-12510: select star on empty table
> nit. Can we add a comment: # Regression test for IMPALA-12510.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/20606
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfa50abfdb9cdb994c5c3d7904b377a25f5b8b97
Gerrit-Change-Number: 20606
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 23 Oct 2023 16:29:33 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12510: Floor PlanFragment.maxParallelism at 1

Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20606 )

Change subject: IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1
......................................................................


Patch Set 1:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/20606/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20606/1//COMMIT_MSG@9
PS1, Line 9: bug
I assume the bug is only happening over an empty table, could you please describe a bit more how the bug looks like, what error it may throw.


http://gerrit.cloudera.org:8080/#/c/20606/1//COMMIT_MSG@14
PS1, Line 14: empty
nit. an empty


http://gerrit.cloudera.org:8080/#/c/20606/1/fe/src/main/java/org/apache/impala/planner/PlanFragment.java
File fe/src/main/java/org/apache/impala/planner/PlanFragment.java:

http://gerrit.cloudera.org:8080/#/c/20606/1/fe/src/main/java/org/apache/impala/planner/PlanFragment.java@1139
PS1, Line 1139: 1
How about sharing the same const mentioned in ScanNode.java? Or maybe use a separate const for this number?


http://gerrit.cloudera.org:8080/#/c/20606/1/fe/src/main/java/org/apache/impala/planner/ScanNode.java
File fe/src/main/java/org/apache/impala/planner/ScanNode.java:

http://gerrit.cloudera.org:8080/#/c/20606/1/fe/src/main/java/org/apache/impala/planner/ScanNode.java@89
PS1, Line 89: 1
How about we name a const for it? Like MIN_SCANNER_THREADS?


http://gerrit.cloudera.org:8080/#/c/20606/1/fe/src/main/java/org/apache/impala/planner/ScanNode.java@373
PS1, Line 373: 1
May use the const mentioned above.



-- 
To view, visit http://gerrit.cloudera.org:8080/20606
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfa50abfdb9cdb994c5c3d7904b377a25f5b8b97
Gerrit-Change-Number: 20606
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 20 Oct 2023 20:58:56 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12510: Floor PlanFragment.maxParallelism at 1

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20606 )

Change subject: IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1
......................................................................


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/20606/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20606/1//COMMIT_MSG@9
PS1, Line 9: bug
> I assume the bug is only happening over an empty table, could you please de
Done


http://gerrit.cloudera.org:8080/#/c/20606/1//COMMIT_MSG@14
PS1, Line 14: oorin
> nit. an empty
Done


http://gerrit.cloudera.org:8080/#/c/20606/1/fe/src/main/java/org/apache/impala/planner/PlanFragment.java
File fe/src/main/java/org/apache/impala/planner/PlanFragment.java:

http://gerrit.cloudera.org:8080/#/c/20606/1/fe/src/main/java/org/apache/impala/planner/PlanFragment.java@1139
PS1, Line 1139: S
> How about sharing the same const mentioned in ScanNode.java? Or maybe use a
Done


http://gerrit.cloudera.org:8080/#/c/20606/1/fe/src/main/java/org/apache/impala/planner/ScanNode.java
File fe/src/main/java/org/apache/impala/planner/ScanNode.java:

http://gerrit.cloudera.org:8080/#/c/20606/1/fe/src/main/java/org/apache/impala/planner/ScanNode.java@89
PS1, Line 89: l
> How about we name a const for it? Like MIN_SCANNER_THREADS?
Done


http://gerrit.cloudera.org:8080/#/c/20606/1/fe/src/main/java/org/apache/impala/planner/ScanNode.java@373
PS1, Line 373: e
> May use the const mentioned above.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/20606
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfa50abfdb9cdb994c5c3d7904b377a25f5b8b97
Gerrit-Change-Number: 20606
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 20 Oct 2023 22:07:45 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12510: Floor PlanFragment.maxParallelism at 1

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20606 )

Change subject: IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1
......................................................................


Patch Set 4: Verified+1

Manually put +1 on Verified vote since IMPALA-12187 is a known flaky test.


-- 
To view, visit http://gerrit.cloudera.org:8080/20606
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfa50abfdb9cdb994c5c3d7904b377a25f5b8b97
Gerrit-Change-Number: 20606
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 23 Oct 2023 22:49:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12510: Floor PlanFragment.maxParallelism at 1

Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20606 )

Change subject: IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

Thanks Riza for the quick fix.

http://gerrit.cloudera.org:8080/#/c/20606/2/fe/src/main/java/org/apache/impala/planner/ScanNode.java
File fe/src/main/java/org/apache/impala/planner/ScanNode.java:

http://gerrit.cloudera.org:8080/#/c/20606/2/fe/src/main/java/org/apache/impala/planner/ScanNode.java@89
PS2, Line 89: 1
nit. seems MIN_NUM_SCAN_THREADS is better


http://gerrit.cloudera.org:8080/#/c/20606/2/testdata/workloads/functional-planner/queries/PlannerTest/tpcds-processing-cost.test
File testdata/workloads/functional-planner/queries/PlannerTest/tpcds-processing-cost.test:

http://gerrit.cloudera.org:8080/#/c/20606/2/testdata/workloads/functional-planner/queries/PlannerTest/tpcds-processing-cost.test@1
PS2, Line 1: # select star on empty table
nit. Can we add a comment: # Regression test for IMPALA-12510.



-- 
To view, visit http://gerrit.cloudera.org:8080/20606
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfa50abfdb9cdb994c5c3d7904b377a25f5b8b97
Gerrit-Change-Number: 20606
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Sat, 21 Oct 2023 02:48:55 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12510: Floor PlanFragment.maxParallelism at 1

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20606 )

Change subject: IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/14221/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20606
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfa50abfdb9cdb994c5c3d7904b377a25f5b8b97
Gerrit-Change-Number: 20606
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 20 Oct 2023 22:34:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12510: Floor PlanFragment.maxParallelism at 1

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Yida Wu, Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20606

to look at the new patch set (#2).

Change subject: IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1
......................................................................

IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1

IMPALA-12444 introduce a bug where PlanFragment.maxParallelism_ can be
set to 0. This can happen at scan fragment if table is empty. Number of
scan ranges will be 0, which then propagate to
ScanNode.maxScannerThreads_ and PlanFragment.maxParallelism_.

This patch fix it by flooring ScanNode.maxScannerThreads_ and
PlanFragment.maxParallelism_ at 1.

Testing:
- Add select star over an empty table testcase to
  PlannerTest.testProcessingCost.

Change-Id: Ibfa50abfdb9cdb994c5c3d7904b377a25f5b8b97
---
M fe/src/main/java/org/apache/impala/planner/PlanFragment.java
M fe/src/main/java/org/apache/impala/planner/ScanNode.java
M testdata/workloads/functional-planner/queries/PlannerTest/tpcds-processing-cost.test
3 files changed, 45 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/20606/2
-- 
To view, visit http://gerrit.cloudera.org:8080/20606
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibfa50abfdb9cdb994c5c3d7904b377a25f5b8b97
Gerrit-Change-Number: 20606
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>

[Impala-ASF-CR] IMPALA-12510: Floor PlanFragment.maxParallelism at 1

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20606 )

Change subject: IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1
......................................................................


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9827/


-- 
To view, visit http://gerrit.cloudera.org:8080/20606
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfa50abfdb9cdb994c5c3d7904b377a25f5b8b97
Gerrit-Change-Number: 20606
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 23 Oct 2023 21:38:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12510: Floor PlanFragment.maxParallelism at 1

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has removed a vote on this change.

Change subject: IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1
......................................................................


Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/20606
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ibfa50abfdb9cdb994c5c3d7904b377a25f5b8b97
Gerrit-Change-Number: 20606
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>

[Impala-ASF-CR] IMPALA-12510: Floor PlanFragment.maxParallelism at 1

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20606 )

Change subject: IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/14220/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20606
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfa50abfdb9cdb994c5c3d7904b377a25f5b8b97
Gerrit-Change-Number: 20606
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 20 Oct 2023 20:10:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12510: Floor PlanFragment.maxParallelism at 1

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20606 )

Change subject: IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20606
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfa50abfdb9cdb994c5c3d7904b377a25f5b8b97
Gerrit-Change-Number: 20606
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 20 Oct 2023 23:22:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12510: Floor PlanFragment.maxParallelism at 1

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20606 )

Change subject: IMPALA-12510: Floor PlanFragment.maxParallelism_ at 1
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/14225/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20606
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfa50abfdb9cdb994c5c3d7904b377a25f5b8b97
Gerrit-Change-Number: 20606
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 23 Oct 2023 17:00:34 +0000
Gerrit-HasComments: No