You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2013/05/05 01:42:16 UTC

[jira] [Resolved] (HBASE-5912) org.apache.hadoop.hbase.ipc.ProtocolSignature.getFingerprint takes significant CPU

     [ https://issues.apache.org/jira/browse/HBASE-5912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack resolved HBASE-5912.
--------------------------

    Resolution: Invalid

Resovling as no longer valid.  We don't do protocol signature anymore (the unimplemented notion that if signatures didn't match, we'd volunteer some other protocol has all been stripped out).  In fact all reflection has been undone from ipc.
                
> org.apache.hadoop.hbase.ipc.ProtocolSignature.getFingerprint takes significant CPU
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-5912
>                 URL: https://issues.apache.org/jira/browse/HBASE-5912
>             Project: HBase
>          Issue Type: Improvement
>          Components: IPC/RPC, Performance
>    Affects Versions: 0.94.1
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hbase-5912.txt
>
>
> I ran oprofile on a YCSB client and found that a large percentage of the CPU time was going to this function:
> 51991     0.4913  25361.jo                 java                     java.lang.reflect.Method[] java.lang.Class.copyMethods(java.lang.reflect.Method[])
> 51384     0.4856  25361.jo                 java                     int org.apache.hadoop.hbase.ipc.ProtocolSignature.getFingerprint(java.lang.reflect.Method)
> 50428     0.4766  25361.jo                 java                     void java.util.Arrays.sort1(int[], int, int)
> We should introduce a simple cache to avoid this overhead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira