You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Jaydeep Vishwakarma <ja...@gmail.com> on 2015/07/03 10:45:25 UTC
Re: Review Request 35340: OOZIE-2187: Add a way to specify a default
JT/RM and NN
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35340/#review90311
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (line 598)
<https://reviews.apache.org/r/35340/#comment143333>
seeing multiple time some strings used like "job-xml", We should use constant to avoid the spell mistake
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (line 602)
<https://reviews.apache.org/r/35340/#comment143332>
format issue
- Jaydeep Vishwakarma
On June 23, 2015, 8:58 p.m., Robert Kanter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35340/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 8:58 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2187
> https://issues.apache.org/jira/browse/OOZIE-2187
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> See this comment:
> https://issues.apache.org/jira/browse/OOZIE-2187?focusedCommentId=14522592&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14522592
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/ActionExecutor.java 07c6d26
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 492ceaf
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java c857011
> core/src/main/resources/oozie-default.xml 4dc127e
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java 0eb1ee0
> core/src/test/resources/wf-schema-no-jobtracker-global.xml PRE-CREATION
> core/src/test/resources/wf-schema-no-jobtracker.xml PRE-CREATION
> core/src/test/resources/wf-schema-no-namenode-global.xml PRE-CREATION
> core/src/test/resources/wf-schema-no-namenode.xml PRE-CREATION
> core/src/test/resources/wf-schema-valid-global-ext.xml 86d274d
>
> Diff: https://reviews.apache.org/r/35340/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Robert Kanter
>
>