[GitHub] [orc] pgaref commented on a change in pull request #637: ORC-747: Abstract Dictionary interface and refactoring

[GitBox <gi...@apache.org>]

pgaref commented on a change in pull request #637:
URL: https://github.com/apache/orc/pull/637#discussion_r578607043



##########
File path: java/core/src/java/org/apache/orc/OrcConf.java
##########
@@ -105,6 +105,11 @@
           "(default 10000 rows) else dictionary check will happen before\n" +
           "writing first stripe. In both cases, the decision to use\n" +
           "dictionary or not will be retained thereafter."),
+  DICTIONARY_IMPL("orc.dictionary.implementation", null,

Review comment:
       hash option missing?

##########
File path: java/core/src/java/org/apache/orc/impl/writer/StringBaseTreeWriter.java
##########
@@ -55,15 +59,32 @@
   // If the number of keys in a dictionary is greater than this fraction of
   //the total number of non-null rows, turn off dictionary encoding
   private final double dictionaryKeySizeThreshold;
+  protected Dictionary dictionary;
   protected boolean useDictionaryEncoding = true;
   private boolean isDirectV2 = true;
   private boolean doneDictionaryCheck;
   private final boolean strideDictionaryCheck;
 
+  static Dictionary createDict(Configuration conf) {

Review comment:
       make private?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org