You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/27 00:38:45 UTC

[GitHub] [spark] zhengruifeng commented on a diff in pull request #36690: [SPARK-39268][FOLLOWUP] Move comment w.r.t. zipWithIndex to correct place

zhengruifeng commented on code in PR #36690:
URL: https://github.com/apache/spark/pull/36690#discussion_r883186161


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/python/AttachDistributedSequenceExec.scala:
##########
@@ -43,11 +43,11 @@ case class AttachDistributedSequenceExec(
   override protected def doExecute(): RDD[InternalRow] = {
     val childRDD = child.execute().map(_.copy())
     val checkpointed = if (childRDD.getNumPartitions > 1) {
-      // to avoid execute multiple jobs. zipWithIndex launches a Spark job.
       childRDD.localCheckpoint()

Review Comment:
   this comment `to avoid execute multiple jobs` refer to `localCheckpoint` here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org