You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/12/30 16:56:16 UTC

[GitHub] [beam] omarismail94 commented on pull request #13410: [BEAM-11327] Replace Charset.defaultCharset() with StandardCharsets.UTF_8

omarismail94 commented on pull request #13410:
URL: https://github.com/apache/beam/pull/13410#issuecomment-752689288


   > I wonder if we could add a rule to avoid this use in the future maybe via [checkstyle](https://github.com/apache/beam/blob/master/sdks/java/build-tools/src/main/resources/beam/checkstyle.xml), otherwise we will be fixing this continuously.
   
   I don't know how checkstyle works, but I can try to figure it out! 
   
   Worst case is just brute-forcing current occurrences of  `Charset.defaultCharset()`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org