[GitHub] [incubator-superset] villebro commented on issue #8594: Create new session for tab migration

[GitBox <gi...@apache.org>]

villebro commented on issue #8594: Create new session for tab migration
URL: https://github.com/apache/incubator-superset/pull/8594#issuecomment-555361240
 
 
   This sounded weird so I did some googling. This turned up:
   
   > If you are using InnoDB or any row-level transactional RDBMS, then it is possible that **any** write transaction can cause a deadlock, even in perfectly normal situations. ... If you catch one, the normal thing to do is just attempt to execute the failed query again.
   
   https://stackoverflow.com/questions/2596005/working-around-mysql-error-deadlock-found-when-trying-to-get-lock-try-restarti/2596101#2596101
   
   So apparently this is mostly MySQL specific (I'm assuming you are using MySQL?), i.e. the recommended course of action is to try the update, catch the deadlock exception and try again. As I hope this isn't common for other backends, perhaps this should be wrapped in a method in the MySQL spec. Not ideal, and might end up cluttering the codebase, so perhaps we need to think this through before making any changes..

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org