You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/23 02:39:11 UTC
[GitHub] [spark] turboFei opened a new pull request #32305: [SPARK-21499][FOLLOWUP] Update doc for registering Spark UDAFs in Spark SQL queries
turboFei opened a new pull request #32305:
URL: https://github.com/apache/spark/pull/32305
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Update doc for registering Spark UDAFs in Spark SQL queries
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To make it more clearly about Spark UDAF for Spark user.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
Existing UT.
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32305: [SPARK-21499][FOLLOWUP] Update doc for registering Spark UDAFs in Spark SQL queries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32305:
URL: https://github.com/apache/spark/pull/32305#issuecomment-825359079
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137842/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32305: [SPARK-21499][FOLLOWUP][DOC] Update doc for registering Spark UDAFs in Spark SQL queries
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32305:
URL: https://github.com/apache/spark/pull/32305#issuecomment-890613501
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32305: [SPARK-21499][FOLLOWUP] Update doc for registering Spark UDAFs in Spark SQL queries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32305:
URL: https://github.com/apache/spark/pull/32305#issuecomment-825371988
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42372/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32305: [SPARK-21499][FOLLOWUP] Update doc for registering Spark UDAFs in Spark SQL queries
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32305:
URL: https://github.com/apache/spark/pull/32305#issuecomment-825355386
**[Test build #137842 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137842/testReport)** for PR 32305 at commit [`3373e44`](https://github.com/apache/spark/commit/3373e448c73e8091f9e4d5dde0e6d86a68718af2).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] turboFei commented on pull request #32305: [SPARK-21499][FOLLOWUP][DOC] Update doc for registering Spark UDAFs in Spark SQL queries
Posted by GitBox <gi...@apache.org>.
turboFei commented on pull request #32305:
URL: https://github.com/apache/spark/pull/32305#issuecomment-825390724
> Kubernetes integration test status failure
> URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42372/
Not related failure.
```
Setting status of 3373e448c73e8091f9e4d5dde0e6d86a68718af2 to FAILURE with url https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42372/ and message: 'Build finished. '
FileNotFoundException means that the credentials Jenkins is using is probably wrong. Or the user account does not have write access to the repo.
org.kohsuke.github.GHFileNotFoundException: https://api.github.com/repos/apache/spark/statuses/3373e448c73e8091f9e4d5dde0e6d86a68718af2 {"message":"Not Found","documentation_url":"https://docs.github.com/rest/reference/repos#create-a-commit-status"}
at org.kohsuke.github.GitHubClient.interpretApiError(GitHubClient.java:492)
at org.kohsuke.github.GitHubClient.sendRequest(GitHubClient.java:420)
at org.kohsuke.github.GitHubClient.sendRequest(GitHubClient.java:363)
at org.kohsuke.github.Requester.fetch(Requester.java:74)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32305: [SPARK-21499][FOLLOWUP] Update doc for registering Spark UDAFs in Spark SQL queries
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32305:
URL: https://github.com/apache/spark/pull/32305#issuecomment-825355386
**[Test build #137842 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137842/testReport)** for PR 32305 at commit [`3373e44`](https://github.com/apache/spark/commit/3373e448c73e8091f9e4d5dde0e6d86a68718af2).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] turboFei commented on a change in pull request #32305: [SPARK-21499][FOLLOWUP] Update doc for registering Spark UDAFs in Spark SQL queries
Posted by GitBox <gi...@apache.org>.
turboFei commented on a change in pull request #32305:
URL: https://github.com/apache/spark/pull/32305#discussion_r618900886
##########
File path: docs/sql-ref-functions-udf-aggregate.md
##########
@@ -21,7 +21,7 @@ license: |
### Description
-User-Defined Aggregate Functions (UDAFs) are user-programmable routines that act on multiple rows at once and return a single aggregated value as a result. This documentation lists the classes that are required for creating and registering UDAFs. It also contains examples that demonstrate how to define and register UDAFs in Scala and invoke them in Spark SQL.
+User-Defined Aggregate Functions (UDAFs) are user-programmable routines that act on multiple rows at once and return a single aggregated value as a result. This documentation lists the classes that are required for creating and registering UDAFs. It also contains examples that demonstrate how to define and register UDAFs in Scala/Spark SQL queries and invoke them in Spark SQL.
Review comment:
scala -> program?
Because there is also java example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32305: [SPARK-21499][FOLLOWUP] Update doc for registering Spark UDAFs in Spark SQL queries
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32305:
URL: https://github.com/apache/spark/pull/32305#issuecomment-825367635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #32305: [SPARK-21499][FOLLOWUP][DOC] Update doc for registering Spark UDAFs in Spark SQL queries
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #32305:
URL: https://github.com/apache/spark/pull/32305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32305: [SPARK-21499][FOLLOWUP] Update doc for registering Spark UDAFs in Spark SQL queries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32305:
URL: https://github.com/apache/spark/pull/32305#issuecomment-825371988
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42372/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32305: [SPARK-21499][FOLLOWUP] Update doc for registering Spark UDAFs in Spark SQL queries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32305:
URL: https://github.com/apache/spark/pull/32305#issuecomment-825359079
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137842/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] turboFei commented on a change in pull request #32305: [SPARK-21499][FOLLOWUP] Update doc for registering Spark UDAFs in Spark SQL queries
Posted by GitBox <gi...@apache.org>.
turboFei commented on a change in pull request #32305:
URL: https://github.com/apache/spark/pull/32305#discussion_r618900886
##########
File path: docs/sql-ref-functions-udf-aggregate.md
##########
@@ -21,7 +21,7 @@ license: |
### Description
-User-Defined Aggregate Functions (UDAFs) are user-programmable routines that act on multiple rows at once and return a single aggregated value as a result. This documentation lists the classes that are required for creating and registering UDAFs. It also contains examples that demonstrate how to define and register UDAFs in Scala and invoke them in Spark SQL.
+User-Defined Aggregate Functions (UDAFs) are user-programmable routines that act on multiple rows at once and return a single aggregated value as a result. This documentation lists the classes that are required for creating and registering UDAFs. It also contains examples that demonstrate how to define and register UDAFs in Scala/Spark SQL queries and invoke them in Spark SQL.
Review comment:
scala -> program?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32305: [SPARK-21499][FOLLOWUP] Update doc for registering Spark UDAFs in Spark SQL queries
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32305:
URL: https://github.com/apache/spark/pull/32305#issuecomment-825358931
**[Test build #137842 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137842/testReport)** for PR 32305 at commit [`3373e44`](https://github.com/apache/spark/commit/3373e448c73e8091f9e4d5dde0e6d86a68718af2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] turboFei commented on a change in pull request #32305: [SPARK-21499][FOLLOWUP] Update doc for registering Spark UDAFs in Spark SQL queries
Posted by GitBox <gi...@apache.org>.
turboFei commented on a change in pull request #32305:
URL: https://github.com/apache/spark/pull/32305#discussion_r618900886
##########
File path: docs/sql-ref-functions-udf-aggregate.md
##########
@@ -21,7 +21,7 @@ license: |
### Description
-User-Defined Aggregate Functions (UDAFs) are user-programmable routines that act on multiple rows at once and return a single aggregated value as a result. This documentation lists the classes that are required for creating and registering UDAFs. It also contains examples that demonstrate how to define and register UDAFs in Scala and invoke them in Spark SQL.
+User-Defined Aggregate Functions (UDAFs) are user-programmable routines that act on multiple rows at once and return a single aggregated value as a result. This documentation lists the classes that are required for creating and registering UDAFs. It also contains examples that demonstrate how to define and register UDAFs in Scala/Spark SQL queries and invoke them in Spark SQL.
Review comment:
scala -> program
Because there is also java example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org