You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/10/06 21:42:53 UTC
Review Request 62820: Added first class profile for disk resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62820/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, James DeFelice, and Joseph Wu.
Bugs: MESOS-8060
https://issues.apache.org/jira/browse/MESOS-8060
Repository: mesos
Description
-------
This is similar to storage classes. Instead of adding a bunch of
storage backend specific parameters (e.g., rotational, type, speed,
etc.) into the disk resources, and asking the frameworks to make
scheduling decisions based on those vendor specific parameters. We
propose to use a level of indirection here.
The operator will setup mappings between a profile name to a set of
vendor specific disk parameters. The framework will do disk selection
based on profile names.
The storage resource provider will provide a hook allowing operators
to customize the profile name assignment for disk resources.
Diffs
-----
include/mesos/mesos.proto 1bfcc5bb9091075c6fa1bc36e2cd23afe2e0e0ec
include/mesos/v1/mesos.proto d742adbbf24692d2d82aad51316d767af93942d5
src/common/resources.cpp ea0f3a28b55bc9e6b52bb2215b39a0f323396246
src/tests/mesos.hpp b0749db273c91692b91d7ca87f975694b18e422c
src/tests/resources_tests.cpp 7f0150ff04b2c5a9a0c47b29a107bad5e363285a
src/v1/resources.cpp a64180bad1d782dd270e06217a389002155c2e10
Diff: https://reviews.apache.org/r/62820/diff/1/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 62820: Added first class profile for disk
resources.
Posted by James DeFelice <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62820/#review187316
-----------------------------------------------------------
Ship it!
Ship It!
- James DeFelice
On Oct. 6, 2017, 9:42 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62820/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2017, 9:42 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Joseph Wu.
>
>
> Bugs: MESOS-8060
> https://issues.apache.org/jira/browse/MESOS-8060
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is similar to storage classes. Instead of adding a bunch of
> storage backend specific parameters (e.g., rotational, type, speed,
> etc.) into the disk resources, and asking the frameworks to make
> scheduling decisions based on those vendor specific parameters. We
> propose to use a level of indirection here.
>
> The operator will setup mappings between a profile name to a set of
> vendor specific disk parameters. The framework will do disk selection
> based on profile names.
>
> The storage resource provider will provide a hook allowing operators
> to customize the profile name assignment for disk resources.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 1bfcc5bb9091075c6fa1bc36e2cd23afe2e0e0ec
> include/mesos/v1/mesos.proto d742adbbf24692d2d82aad51316d767af93942d5
> src/common/resources.cpp ea0f3a28b55bc9e6b52bb2215b39a0f323396246
> src/tests/mesos.hpp b0749db273c91692b91d7ca87f975694b18e422c
> src/tests/resources_tests.cpp 7f0150ff04b2c5a9a0c47b29a107bad5e363285a
> src/v1/resources.cpp a64180bad1d782dd270e06217a389002155c2e10
>
>
> Diff: https://reviews.apache.org/r/62820/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62820: Added first class profile for disk
resources.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62820/#review187305
-----------------------------------------------------------
FAIL: The system cannot find the file specified.
Reviews applied: `['62806']`
Failed command: `C:\mesos\src\mesos-tests.exe --verbose --gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806/logs/mesos-tests-stdout.log):
```
[ RUN ] FaultToleranceTest.SchedulerReregisterAfterUnregistration
[ OK ] FaultToleranceTest.SchedulerReregisterAfterUnregistration (389 ms)
[ RUN ] FaultToleranceTest.SchedulerFailoverRetriedReregistration
[ OK ] FaultToleranceTest.SchedulerFailoverRetriedReregistration (389 ms)
[ RUN ] FaultToleranceTest.DisconnectedSchedulerLaunchLost
[ OK ] FaultToleranceTest.DisconnectedSchedulerLaunchLost (609 ms)
[ RUN ] FaultToleranceTest.DisconnectedSchedulerLaunchDropped
[ OK ] FaultToleranceTest.DisconnectedSchedulerLaunchDropped (596 ms)
[ RUN ] FaultToleranceTest.SchedulerFailoverStatusUpdate
[ OK ] FaultToleranceTest.SchedulerFailoverStatusUpdate (923 ms)
[ RUN ] FaultToleranceTest.ReregisterFrameworkExitedExecutor
[ OK ] FaultToleranceTest.ReregisterFrameworkExitedExecutor (1249 ms)
[ RUN ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor
[ OK ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor (822 ms)
[ RUN ] FaultToleranceTest.SchedulerFailoverExecutorToFrameworkMessage
[ OK ] FaultToleranceTest.SchedulerFailoverExecutorToFrameworkMessage (941 ms)
[ RUN ] FaultToleranceTest.SchedulerFailoverFrameworkToExecutorMessage
[ OK ] FaultToleranceTest.SchedulerFailoverFrameworkToExecutorMessage (1060 ms)
[ RUN ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework
[ OK ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework (939 ms)
[ RUN ] FaultToleranceTest.SchedulerExit
[ OK ] FaultToleranceTest.SchedulerExit (841 ms)
[ RUN ] FaultToleranceTest.SlaveReliableRegistration
[ OK ] FaultToleranceTest.SlaveReliableRegistration (788 ms)
[ RUN ] FaultToleranceTest.SlaveReregisterOnZKExpiration
[ OK ] FaultToleranceTest.SlaveReregisterOnZKExpiration (778 ms)
[ RUN ] FaultToleranceTest.FrameworkReregisterEmptyExecutor
[ OK ] FaultToleranceTest.FrameworkReregisterEmptyExecutor (1130 ms)
[ RUN ] FaultToleranceTest.SplitBrainMasters
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806/logs/mesos-tests-stderr.log):
```
I1006 17:26:12.991288 43216 master.cpp:8459] Removing framework ede9e20a-4e06-46fb-a22c-7e8013f03fa7-0000 (default) at scheduler-3a38ff4a-a81c-4c5b-9c40-38d63a94afd2@10.3.1.5:61771
I1006 17:26:12.991288 43216 master.cpp:3299] Deactivating framework ede9e20a-4e06-46fb-a22c-7e8013f03fa7-0000 (default) at scheduler-3a38ff4a-a81c-4c5b-9c40-38d63a94afd2@10.3.1.5:61771
I1006 17:26:12.992297 46984 hierarchical.cpp:412] Deactivated framework ede9e20a-4e06-46fb-a22c-7e8013f03fa7-0000
I1006 17:26:12.995283 43216 master.cpp:9389] Removing offer 60f5153f-ffdc-4156-8383-39cf5a6b25f8-O0
I1006 17:26:12.998283 46248 slave.cpp:869] Agent terminating
I1006 17:26:13.004289 21464 hierarchical.cpp:355] Removed framework ede9e20a-4e06-46fb-a22c-7e8013f03fa7-0000
I1006 17:26:13.007899 39284 master.cpp:1303] Agent ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1006 17:26:13.008906 39284 master.cpp:3336] Disconnecting agent ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 17:26:13.008906 39284 master.cpp:3355] Deactivating agent ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 17:26:13.009905 46484 hierarchical.cpp:690] Agent ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 deactivated
I1006 17:26:13.038906 46248 master.cpp:1145] Master terminating
I1006 17:26:13.040907 21464 hierarchical.cpp:626] Removed agent ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0
I1006 17:26:13.151911 46248 cluster.cpp:162] Creating default 'local' authorizer
I1006 17:26:13.184912 44660 master.cpp:445] Master 8c8fa538-3ba3-4608-8e12-2ba9b5151087 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) started on 10.3.1.5:61771
I1006 17:26:13.184912 44660 master.cpp:447] Flags at startup: --acls="" --agent_ping_timeout="15secs" --agent_reregister_timeout="10mins" --allocation_interval="1secs" --allocator="HierarchicalDRF" --authenticate_agents="true" --authenticate_frameworks="true" --authenticate_http_frameworks="true" --authenticate_http_readonly="true" --authenticate_http_readwrite="true" --authenticators="crammd5" --authorizers="local" --credentials="C:\Users\mesos\AppData\Local\Temp\2\BVZ2va\credentials" --filter_gpu_resources="true" --framework_sorter="drf" --help="false" --hostname_lookup="true" --http_authenticators="basic" --http_framework_authenticators="basic" --initialize_driver_logging="true" --log_auto_initialize="true" --logbufsecs="0" --logging_level="INFO" --max_agent_ping_timeouts="5" --max_completed_frameworks="50" --max_completed_tasks_per_framework="1000" --max_unreachable_tasks_per_framework="1000" --port="5050" --quiet="false" --recovery_agent_removal_limit="100%" --registry="in_memor
y" --registry_fetch_timeout="1mins" --registry_gc_interval="15mins" --registry_max_agent_age="2weeks" --registry_max_agent_count="102400" --registry_store_timeout="100secs" --registry_strict="false" --root_submissions="true" --user_sorter="drf" --version="false" --webui_dir="/webui" --work_dir="C:\Users\mesos\AppData\Local\Temp\2\BVZ2va\master" --zk_session_timeout="10secs"
I1006 17:26:13.223922 44660 master.cpp:496] Master only allowing authenticated frameworks to register
I1006 17:26:13.223922 44660 master.cpp:502] Master only allowing authenticated agents to register
I1006 17:26:13.223922 44660 master.cpp:508] Master only allowing authenticated HTTP frameworks to register
I1006 17:26:13.223922 44660 credentials.hpp:37] Loading credentials for authentication from 'C:\Users\mesos\AppData\Local\Temp\2\BVZ2va\credentials'
I1006 17:26:13.235913 44660 master.cpp:552] Using default 'crammd5' authenticator
I1006 17:26:13.236914 44660 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-master-readonly'
I1006 17:26:13.237915 44660 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-master-readwrite'
I1006 17:26:13.238914 44660 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-master-scheduler'
I1006 17:26:13.239914 44660 master.cpp:631] Authorization enabled
I1006 17:26:13.270947 45764 master.cpp:2198] Elected as the leading master!
I1006 17:26:13.270947 45764 master.cpp:1687] Recovering from registrar
I1006 17:26:13.273921 39284 registrar.cpp:391] Successfully fetched the registry (0B) in 1.97504ms
I1006 17:26:13.273921 39284 registrar.cpp:495] Applied 1 operations in 0ns; attempting to update the registry
I1006 17:26:13.275921 21464 registrar.cpp:552] Successfully updated the registry in 999936ns
I1006 17:26:13.276916 21464 registrar.cpp:424] Success```
- Mesos Reviewbot Windows
On Oct. 6, 2017, 9:42 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62820/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2017, 9:42 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Joseph Wu.
>
>
> Bugs: MESOS-8060
> https://issues.apache.org/jira/browse/MESOS-8060
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is similar to storage classes. Instead of adding a bunch of
> storage backend specific parameters (e.g., rotational, type, speed,
> etc.) into the disk resources, and asking the frameworks to make
> scheduling decisions based on those vendor specific parameters. We
> propose to use a level of indirection here.
>
> The operator will setup mappings between a profile name to a set of
> vendor specific disk parameters. The framework will do disk selection
> based on profile names.
>
> The storage resource provider will provide a hook allowing operators
> to customize the profile name assignment for disk resources.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 1bfcc5bb9091075c6fa1bc36e2cd23afe2e0e0ec
> include/mesos/v1/mesos.proto d742adbbf24692d2d82aad51316d767af93942d5
> src/common/resources.cpp ea0f3a28b55bc9e6b52bb2215b39a0f323396246
> src/tests/mesos.hpp b0749db273c91692b91d7ca87f975694b18e422c
> src/tests/resources_tests.cpp 7f0150ff04b2c5a9a0c47b29a107bad5e363285a
> src/v1/resources.cpp a64180bad1d782dd270e06217a389002155c2e10
>
>
> Diff: https://reviews.apache.org/r/62820/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62820: Added first class profile for disk
resources.
Posted by James DeFelice <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62820/#review187318
-----------------------------------------------------------
- James DeFelice
On Oct. 6, 2017, 9:42 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62820/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2017, 9:42 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Joseph Wu.
>
>
> Bugs: MESOS-8060
> https://issues.apache.org/jira/browse/MESOS-8060
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is similar to storage classes. Instead of adding a bunch of
> storage backend specific parameters (e.g., rotational, type, speed,
> etc.) into the disk resources, and asking the frameworks to make
> scheduling decisions based on those vendor specific parameters. We
> propose to use a level of indirection here.
>
> The operator will setup mappings between a profile name to a set of
> vendor specific disk parameters. The framework will do disk selection
> based on profile names.
>
> The storage resource provider will provide a hook allowing operators
> to customize the profile name assignment for disk resources.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 1bfcc5bb9091075c6fa1bc36e2cd23afe2e0e0ec
> include/mesos/v1/mesos.proto d742adbbf24692d2d82aad51316d767af93942d5
> src/common/resources.cpp ea0f3a28b55bc9e6b52bb2215b39a0f323396246
> src/tests/mesos.hpp b0749db273c91692b91d7ca87f975694b18e422c
> src/tests/resources_tests.cpp 7f0150ff04b2c5a9a0c47b29a107bad5e363285a
> src/v1/resources.cpp a64180bad1d782dd270e06217a389002155c2e10
>
>
> Diff: https://reviews.apache.org/r/62820/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62820: Added first class profile for disk
resources.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62820/#review187306
-----------------------------------------------------------
FAIL: The system cannot find the file specified.
Reviews applied: `['62806']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806
- Mesos Reviewbot Windows
On Oct. 6, 2017, 9:42 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62820/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2017, 9:42 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Joseph Wu.
>
>
> Bugs: MESOS-8060
> https://issues.apache.org/jira/browse/MESOS-8060
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is similar to storage classes. Instead of adding a bunch of
> storage backend specific parameters (e.g., rotational, type, speed,
> etc.) into the disk resources, and asking the frameworks to make
> scheduling decisions based on those vendor specific parameters. We
> propose to use a level of indirection here.
>
> The operator will setup mappings between a profile name to a set of
> vendor specific disk parameters. The framework will do disk selection
> based on profile names.
>
> The storage resource provider will provide a hook allowing operators
> to customize the profile name assignment for disk resources.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 1bfcc5bb9091075c6fa1bc36e2cd23afe2e0e0ec
> include/mesos/v1/mesos.proto d742adbbf24692d2d82aad51316d767af93942d5
> src/common/resources.cpp ea0f3a28b55bc9e6b52bb2215b39a0f323396246
> src/tests/mesos.hpp b0749db273c91692b91d7ca87f975694b18e422c
> src/tests/resources_tests.cpp 7f0150ff04b2c5a9a0c47b29a107bad5e363285a
> src/v1/resources.cpp a64180bad1d782dd270e06217a389002155c2e10
>
>
> Diff: https://reviews.apache.org/r/62820/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62820: Added first class profile for disk
resources.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62820/#review187333
-----------------------------------------------------------
Patch looks great!
Reviews applied: [62818, 62819, 62820]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 6, 2017, 9:42 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62820/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2017, 9:42 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Joseph Wu.
>
>
> Bugs: MESOS-8060
> https://issues.apache.org/jira/browse/MESOS-8060
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is similar to storage classes. Instead of adding a bunch of
> storage backend specific parameters (e.g., rotational, type, speed,
> etc.) into the disk resources, and asking the frameworks to make
> scheduling decisions based on those vendor specific parameters. We
> propose to use a level of indirection here.
>
> The operator will setup mappings between a profile name to a set of
> vendor specific disk parameters. The framework will do disk selection
> based on profile names.
>
> The storage resource provider will provide a hook allowing operators
> to customize the profile name assignment for disk resources.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 1bfcc5bb9091075c6fa1bc36e2cd23afe2e0e0ec
> include/mesos/v1/mesos.proto d742adbbf24692d2d82aad51316d767af93942d5
> src/common/resources.cpp ea0f3a28b55bc9e6b52bb2215b39a0f323396246
> src/tests/mesos.hpp b0749db273c91692b91d7ca87f975694b18e422c
> src/tests/resources_tests.cpp 7f0150ff04b2c5a9a0c47b29a107bad5e363285a
> src/v1/resources.cpp a64180bad1d782dd270e06217a389002155c2e10
>
>
> Diff: https://reviews.apache.org/r/62820/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62820: Added first class profile for disk
resources.
Posted by Jie Yu <yu...@gmail.com>.
> On Oct. 9, 2017, 8:36 p.m., Joseph Wu wrote:
> > src/tests/mesos.hpp
> > Lines 980 (patched)
> > <https://reviews.apache.org/r/62820/diff/1/?file=1847993#file1847993line982>
> >
> > This should be `mutable_mount()`
Good catch! thanks!
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62820/#review187446
-----------------------------------------------------------
On Oct. 6, 2017, 9:42 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62820/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2017, 9:42 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Joseph Wu.
>
>
> Bugs: MESOS-8060
> https://issues.apache.org/jira/browse/MESOS-8060
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is similar to storage classes. Instead of adding a bunch of
> storage backend specific parameters (e.g., rotational, type, speed,
> etc.) into the disk resources, and asking the frameworks to make
> scheduling decisions based on those vendor specific parameters. We
> propose to use a level of indirection here.
>
> The operator will setup mappings between a profile name to a set of
> vendor specific disk parameters. The framework will do disk selection
> based on profile names.
>
> The storage resource provider will provide a hook allowing operators
> to customize the profile name assignment for disk resources.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 1bfcc5bb9091075c6fa1bc36e2cd23afe2e0e0ec
> include/mesos/v1/mesos.proto d742adbbf24692d2d82aad51316d767af93942d5
> src/common/resources.cpp ea0f3a28b55bc9e6b52bb2215b39a0f323396246
> src/tests/mesos.hpp b0749db273c91692b91d7ca87f975694b18e422c
> src/tests/resources_tests.cpp 7f0150ff04b2c5a9a0c47b29a107bad5e363285a
> src/v1/resources.cpp a64180bad1d782dd270e06217a389002155c2e10
>
>
> Diff: https://reviews.apache.org/r/62820/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62820: Added first class profile for disk
resources.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62820/#review187446
-----------------------------------------------------------
Fix it, then Ship it!
Looks reasonable to me.
src/tests/mesos.hpp
Lines 980 (patched)
<https://reviews.apache.org/r/62820/#comment264416>
This should be `mutable_mount()`
- Joseph Wu
On Oct. 6, 2017, 2:42 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62820/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2017, 2:42 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Joseph Wu.
>
>
> Bugs: MESOS-8060
> https://issues.apache.org/jira/browse/MESOS-8060
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is similar to storage classes. Instead of adding a bunch of
> storage backend specific parameters (e.g., rotational, type, speed,
> etc.) into the disk resources, and asking the frameworks to make
> scheduling decisions based on those vendor specific parameters. We
> propose to use a level of indirection here.
>
> The operator will setup mappings between a profile name to a set of
> vendor specific disk parameters. The framework will do disk selection
> based on profile names.
>
> The storage resource provider will provide a hook allowing operators
> to customize the profile name assignment for disk resources.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 1bfcc5bb9091075c6fa1bc36e2cd23afe2e0e0ec
> include/mesos/v1/mesos.proto d742adbbf24692d2d82aad51316d767af93942d5
> src/common/resources.cpp ea0f3a28b55bc9e6b52bb2215b39a0f323396246
> src/tests/mesos.hpp b0749db273c91692b91d7ca87f975694b18e422c
> src/tests/resources_tests.cpp 7f0150ff04b2c5a9a0c47b29a107bad5e363285a
> src/v1/resources.cpp a64180bad1d782dd270e06217a389002155c2e10
>
>
> Diff: https://reviews.apache.org/r/62820/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>