[jira] [Commented] (CASSANDRA-11168) Hint Metrics are updated even if hinted_hand-offs=false

["Aleksey Yeschenko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-11168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15173961#comment-15173961 ] 

Aleksey Yeschenko commented on CASSANDRA-11168:
-----------------------------------------------

I don't think this really matters. That said, I'm slightly inclined towards making the suggested change (only increment if hints are both enabled and past window).

> Hint Metrics are updated even if hinted_hand-offs=false
> -------------------------------------------------------
>
>                 Key: CASSANDRA-11168
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11168
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Anubhav Kale
>            Assignee: Anubhav Kale
>            Priority: Minor
>         Attachments: 0001-Hinted-Handoff-Fix.patch
>
>
> In our PROD logs, we noticed a lot of hint metrics even though we have disabled hinted handoffs.
> The reason is StorageProxy.ShouldHint has an inverted if condition. 
> We should also wrap the if (hintWindowExpired) block in if (DatabaseDescriptor.hintedHandoffEnabled()).
> The fix is easy, and I can provide a patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)