You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/06/16 03:50:33 UTC
[GitHub] [zookeeper] jhuan31 opened a new pull request #1381: ZOOKEEPER-3864: Reject create/renew/close global session in RO mode
jhuan31 opened a new pull request #1381:
URL: https://github.com/apache/zookeeper/pull/1381
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] hanm commented on pull request #1381: ZOOKEEPER-3864: Reject create/renew/close global session in RO mode
Posted by GitBox <gi...@apache.org>.
hanm commented on pull request #1381:
URL: https://github.com/apache/zookeeper/pull/1381#issuecomment-646315117
also, should we combine https://github.com/apache/zookeeper/pull/1380 with this pull request? Logically, both are separate issues, but since this patch depends on PR1380 (which itself does not come with any unit test), I am thinking combine both in a single PR might be better (and probably easier to get all test pass).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] jhuan31 closed pull request #1381: ZOOKEEPER-3864: Reject create/renew/close global session in RO mode
Posted by GitBox <gi...@apache.org>.
jhuan31 closed pull request #1381:
URL: https://github.com/apache/zookeeper/pull/1381
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] jhuan31 commented on pull request #1381: ZOOKEEPER-3864: Reject create/renew/close global session in RO mode
Posted by GitBox <gi...@apache.org>.
jhuan31 commented on pull request #1381:
URL: https://github.com/apache/zookeeper/pull/1381#issuecomment-644872883
looks like an infra issue. it failed only on s390x and the error msg is "An error occurred while generating the build script.An error occurred while generating the build script."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] jhuan31 commented on pull request #1381: ZOOKEEPER-3864: Reject create/renew/close global session in RO mode
Posted by GitBox <gi...@apache.org>.
jhuan31 commented on pull request #1381:
URL: https://github.com/apache/zookeeper/pull/1381#issuecomment-645564128
Need to have ZOOKEEPER-3863, which replace SessionTrackerImpl with LearnerSessionTracker for ReadOnlyServer, to make this PR work coz SessionTrackerImpl can't whether a session is global or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] jhuan31 commented on pull request #1381: ZOOKEEPER-3864: Reject create/renew/close global session in RO mode
Posted by GitBox <gi...@apache.org>.
jhuan31 commented on pull request #1381:
URL: https://github.com/apache/zookeeper/pull/1381#issuecomment-647920850
Combine this PR with #1380
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] jhuan31 closed pull request #1381: ZOOKEEPER-3864: Reject create/renew/close global session in RO mode
Posted by GitBox <gi...@apache.org>.
jhuan31 closed pull request #1381:
URL: https://github.com/apache/zookeeper/pull/1381
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] jhuan31 commented on pull request #1381: ZOOKEEPER-3864: Reject create/renew/close global session in RO mode
Posted by GitBox <gi...@apache.org>.
jhuan31 commented on pull request #1381:
URL: https://github.com/apache/zookeeper/pull/1381#issuecomment-645547378
@hanm I think there is something wrong with ReadOnlyModeTest: some tests depend on renewing a global session, which is rejected by this change. The check result of the continuous integration is very confusing though--it doesn't show any test failure. Trying to fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] hanm commented on pull request #1381: ZOOKEEPER-3864: Reject create/renew/close global session in RO mode
Posted by GitBox <gi...@apache.org>.
hanm commented on pull request #1381:
URL: https://github.com/apache/zookeeper/pull/1381#issuecomment-646313962
Yes, `ReadOnlyModeTest` is failing because of this. https://github.com/apache/zookeeper/pull/1380 doesn't seem to fix all the tests though - I tried to apply that to my local clone of this patch and all tests still failing. Let's fix all tests before landing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org