You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by jo...@apache.org on 2024/10/27 13:13:10 UTC
(sling-org-apache-sling-servlets-resolver) 04/05: Also log the error message
This is an automated email from the ASF dual-hosted git repository.
joerghoh pushed a commit to branch SLING-12461
in repository https://gitbox.apache.org/repos/asf/sling-org-apache-sling-servlets-resolver.git
commit a08d21306f9c1c6174d9b561f4ef024b7a8f35c0
Author: Joerg Hoh <jo...@apache.org>
AuthorDate: Sun Oct 27 13:45:57 2024 +0100
Also log the error message
If this code is invoked at any later point in the rendering process where the status code cannot be changed anymore, it will leave no obvious trace in the logs that no servlet could have been resolved and this functionality get invoked.
---
.../resolver/internal/defaults/DefaultServlet.java | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/src/main/java/org/apache/sling/servlets/resolver/internal/defaults/DefaultServlet.java b/src/main/java/org/apache/sling/servlets/resolver/internal/defaults/DefaultServlet.java
index c2d1110..fc13383 100644
--- a/src/main/java/org/apache/sling/servlets/resolver/internal/defaults/DefaultServlet.java
+++ b/src/main/java/org/apache/sling/servlets/resolver/internal/defaults/DefaultServlet.java
@@ -27,6 +27,8 @@ import org.apache.sling.api.SlingHttpServletResponse;
import org.apache.sling.api.resource.NonExistingResource;
import org.apache.sling.api.resource.Resource;
import org.apache.sling.api.servlets.SlingSafeMethodsServlet;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
* The <code>DefaultServlet</code> is a very simple default resource handler.
@@ -37,6 +39,8 @@ import org.apache.sling.api.servlets.SlingSafeMethodsServlet;
public class DefaultServlet extends SlingSafeMethodsServlet {
private static final long serialVersionUID = 3806788918045433043L;
+
+ private static final Logger LOG = LoggerFactory.getLogger(DefaultServlet.class);
@Override
protected void doGet(SlingHttpServletRequest request,
@@ -46,11 +50,13 @@ public class DefaultServlet extends SlingSafeMethodsServlet {
// cannot handle the request for missing resources
if (resource instanceof NonExistingResource) {
- response.sendError(HttpServletResponse.SC_NOT_FOUND,
- "Resource not found at path " + resource.getPath());
+ String msg = String.format("Resource not found at path %s", resource.getPath());
+ LOG.error(msg);
+ response.sendError(HttpServletResponse.SC_NOT_FOUND,msg);
} else {
- response.sendError(HttpServletResponse.SC_INTERNAL_SERVER_ERROR,
- "Cannot find servlet to handle resource " + resource.getPath());
+ String msg = String.format("Cannot find servlet to handle resource %s", resource.getPath());
+ LOG.error(msg);
+ response.sendError(HttpServletResponse.SC_INTERNAL_SERVER_ERROR,msg);
}
}